Track node group hub nodes when a node group member's tracking header is 'always'

desplesda · desplesda · commit 96396749aa94 · 2025-07-04T10:43:39.000+10:00
diff --git a/YarnSpinner.Compiler/Visitors/NodeTrackingVisitor.cs b/YarnSpinner.Compiler/Visitors/NodeTrackingVisitor.cs
@@ -60,6 +60,14 @@ public NodeTrackingVisitor(HashSet<string> ExistingTrackedNodes, HashSet<string>
                 if (tracking.Equals("always"))
                 {
                     TrackingNode.Add(title);
+                    // If we're in a node group, 'title' is actually our
+                    // rewritten individual node title. We'll track that, but we
+                    // also need to track the hub node, so we'll also add that
+                    // to the tracking list.
+                    if (string.IsNullOrEmpty(context.NodeGroup) == false)
+                    {
+                        TrackingNode.Add(context.NodeGroup);
+                    }
                 }
                 else if (tracking.Equals("never"))
                 {

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,14 @@ public NodeTrackingVisitor(HashSet<string> ExistingTrackedNodes, HashSet<string>`
`60`	`60`	`if (tracking.Equals("always"))`
`61`	`61`	`{`
`62`	`62`	`TrackingNode.Add(title);`
	`63`	`+ // If we're in a node group, 'title' is actually our`
	`64`	`+ // rewritten individual node title. We'll track that, but we`
	`65`	`+ // also need to track the hub node, so we'll also add that`
	`66`	`+ // to the tracking list.`
	`67`	`+ if (string.IsNullOrEmpty(context.NodeGroup) == false)`
	`68`	`+ {`
	`69`	`+ TrackingNode.Add(context.NodeGroup);`
	`70`	`+ }`
`63`	`71`	`}`
`64`	`72`	`else if (tracking.Equals("never"))`
`65`	`73`	`{`