Store ranges in LineInfos, not Positions

Author: desplesda

CHANGELOG.md

@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 - Complexity scoring for `when:` headers no longer counts `not` operations. This means that `when: $x` and `when: not $x` have the same score of 1.
 - `VirtualMachine.ContentSaliencyStrategy` now defaults to `RandomBestLeastRecentlyViewed`, not `First`
+- `NodeDebugInfo.LineInfo` now stores ranges of text, rather than just the start position.
 
 ### Removed
 

YarnSpinner.Compiler/DebugInfo.cs

@@ -139,16 +139,13 @@ internal void AddLabel(string label, int instructionIndex)
         /// number of instructions present in the node.</exception>
         public LineInfo GetLineInfo(int instructionNumber)
         {
-            if (this.LineRanges.TryGetValue(instructionNumber, out var info))
+            if (this.LineRanges.TryGetValue(instructionNumber, out var range))
             {
                 return new LineInfo
                 {
                     FileName = this.FileName,
                     NodeName = this.NodeName,
-                    Position = new Position(
-                        info.Start.Line,
-                        info.Start.Character
-                    ),
+                    Range = range,
                 };
             }
             else
@@ -175,10 +172,10 @@ public struct LineInfo
             public string NodeName;
 
             /// <summary>
-            /// The position in <see cref="FileName"/> that contains the
+            /// The range in <see cref="FileName"/> that contains the
             /// statement or expression that this line was produced from.
             /// </summary>
-            public Position Position;
+            public Range Range;
         }
     }
 }

YarnSpinner.Tests/ProjectTests.cs

@@ -406,8 +406,8 @@ public void TestDebugOutputIsProduced()
 
             firstLineInfo.FileName.Should().Be("input");
             firstLineInfo.NodeName.Should().Be("DebugTesting");
-            firstLineInfo.Position.Line.Should().Be(2);
-            firstLineInfo.Position.Character.Should().Be(0);
+            firstLineInfo.Range.Start.Line.Should().Be(2);
+            firstLineInfo.Range.Start.Character.Should().Be(0);
         }
     }
 }