Merge pull request #415 from pappleby/ls-compile-include-shadowlines

Bugfix: Language Server Compile command should include strings and metadata for shadow lines

Author: desplesda

CHANGELOG.md

@@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Fixed an issue that would cause testplans with syntax errors to incorrectly pass.
 - Fixed an issue where using `visited()` or `visited_count()` would not correctly track visiting node groups.
 - Language Server: NodeInfo objects now indicate whether a node contains any jumps to nodes in a different file.
+- Language Server: Fixed an issue where the Compile workspace command output was missing shadow lines
 - Language Server: `Microsoft.CodeAnalysis.CSharp` package updated to v4.14.0, fixing command detection in C# files using recent syntax added to C# (eg. `Required Members` from C# 11)
 
 ### Removed

YarnSpinner.LanguageServer.Tests/ReferenceTests.cs

@@ -48,7 +48,7 @@ public async Task Workspace_FindsReferencesToNodes()
             {
 
                 node1.References.Should().HaveCount(2);
-                node1.Jumps.Should().HaveCount(1);
+                node1.Jumps.Should().HaveCount(2);
                 node1.Jumps.Should().Contain(j => j.DestinationTitle == "Node2" && j.Type == NodeJump.JumpType.Jump);
 
                 node2.References.Should().HaveCount(3);

YarnSpinner.LanguageServer/src/Server/YarnLanguageServer.cs

@@ -608,12 +608,7 @@ private static Task<CompilerOutput> CompileCurrentProjectAsync(Workspace workspa
 
             foreach (var line in result.StringTable ?? Enumerable.Empty<KeyValuePair<string, Yarn.Compiler.StringInfo>>())
             {
-                if (line.Value.text == null)
-                {
-                    continue;
-                }
-
-                strings[line.Key] = line.Value.text;
+                strings[line.Key] = line.Value.text ?? string.Empty;
 
                 var metadataEntry = new MetadataOutput
                 {