Skip to content

Commit e1fe4d3

Browse files
committed
Slightly tidyup
1 parent 6f31bb7 commit e1fe4d3

File tree

2 files changed

+8
-18
lines changed

2 files changed

+8
-18
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
4747
- Fixed a bug where self-closing replacement markup was consuming whitespace
4848
- `IAttributeMarkerProcessor.ProcessReplacementMarker` now returns a `ReplacementMarkerResult` struct instead of just a list of diagnostics.
4949
- Type Checker: Fixed a crash that could occur if multiple declarations with the same name were provided.
50+
- `Dialogue.LogDebugMessage` and `Dialogue.LogErrorMessage` now wrap the values of `VirtualMachine.LogDebugMessage and VirtualMachine.LogErrorMessage`, respectively.
5051
5152
### Removed
5253

YarnSpinner/Dialogue.cs

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -557,36 +557,25 @@ public class Dialogue : ISmartVariableEvaluator
557557
/// </summary>
558558
public Logger? LogDebugMessage
559559
{
560-
get
561-
{
562-
return vm.LogDebugMessage;
563-
}
564-
set
565-
{
566-
vm.LogDebugMessage = value;
567-
}
560+
get => vm.LogDebugMessage;
561+
set => vm.LogDebugMessage = value;
568562
}
569563

570564
/// <summary>
571565
/// Invoked when the Dialogue needs to report an error.
572566
/// </summary>
573567
public Logger? LogErrorMessage
574568
{
575-
get
576-
{
577-
return vm.LogErrorMessage;
578-
}
579-
set
580-
{
581-
vm.LogErrorMessage = value;
582-
}
569+
get => vm.LogErrorMessage;
570+
set => vm.LogErrorMessage = value;
583571
}
584572

585-
/// <summary>The node that execution will start from.</summary>
573+
/// <summary>The default name of the node that execution will start
574+
/// from.</summary>
586575
public const string DefaultStartNodeName = "Start";
587576

588577
/// <summary>
589-
/// The value to indicate to the dialogue runner that no option was selected and dialogue should fallthrough to the rest of the program.
578+
/// The value to indicate to the dialogue runner that no option was selected and dialogue should fall through to the rest of the program.
590579
/// </summary>
591580
public const int NoOptionSelected = -1;
592581

0 commit comments

Comments
 (0)