chore: remove lodash dependency

Many functionalities previously offered by lodash are now available natively or can be implemented easily using current Node.js features. This change reduces project dependencies.

Author: YasharF

README.md

@@ -545,7 +545,6 @@ Required to run the project before your modifications
 | express-session               | Simple session middleware for Express.                                |
 | jquery                        | Front-end JS library to interact with HTML elements.                  |
 | lastfm                        | Last.fm API library.                                                  |
-| lodash                        | A utility library for working with arrays, numbers, objects, strings. |
 | lusca                         | CSRF middleware.                                                      |
 | mailchecker                   | Verifies that an email address is valid and not a disposable address. |
 | moment                        | Parse, validate, compute dates and times.                             |

config/passport.js

@@ -12,7 +12,6 @@ const { OAuthStrategy } = require('passport-oauth');
 const { OAuth2Strategy } = require('passport-oauth');
 const OpenIDConnectStrategy = require('passport-openidconnect');
 const { OAuth } = require('oauth');
-const _ = require('lodash');
 const moment = require('moment');
 
 const User = require('../models/User');
@@ -254,7 +253,14 @@ passport.use(
         if (existingUser) {
           return done(null, existingUser);
         }
-        const emailValue = _.get(_.orderBy(profile.emails, ['primary', 'verified'], ['desc', 'desc']), [0, 'value'], null);
+        // Github may return a list of email addresses instead of just one
+        // Sort by primary, then by verified, then pick the first one in the list
+        const sortedEmails = (profile.emails || []).slice().sort((a, b) => {
+          if (b.primary !== a.primary) return b.primary - a.primary;
+          if (b.verified !== a.verified) return b.verified - a.verified;
+          return 0;
+        });
+        const emailValue = sortedEmails.length > 0 ? sortedEmails[0].value : null;
         if (profile._json.email === null) {
           const existingEmailUser = await User.findOne({
             email: { $eq: emailValue },

controllers/user.js

@@ -1,6 +1,5 @@
 const crypto = require('crypto');
 const passport = require('passport');
-const _ = require('lodash');
 const validator = require('validator');
 const mailChecker = require('mailchecker');
 const User = require('../models/User');
@@ -325,14 +324,14 @@ exports.getOauthUnlink = async (req, res, next) => {
     // that another login method exists.
     if (!(user.email && user.password) && tokensWithoutProviderToUnlink.length === 0) {
       req.flash('errors', {
-        msg: `The ${_.startCase(_.toLower(provider))} account cannot be unlinked without another form of login enabled. Please link another account or add an email address and password.`,
+        msg: `The ${provider.charAt(0).toUpperCase() + provider.slice(1).toLowerCase()} account cannot be unlinked without another form of login enabled. Please link another account or add an email address and password.`,
       });
       return res.redirect('/account');
     }
     user.tokens = tokensWithoutProviderToUnlink;
     await user.save();
     req.flash('info', {
-      msg: `${_.startCase(_.toLower(provider))} account has been unlinked.`,
+      msg: `${provider.charAt(0).toUpperCase() + provider.slice(1).toLowerCase()} account has been unlinked.`,
     });
     res.redirect('/account');
   } catch (err) {

package-lock.json

@@ -46,7 +46,6 @@
     "express-session": "^1.18.1",
     "jquery": "^3.7.1",
     "lastfm": "^0.9.4",
-    "lodash": "^4.17.21",
     "lusca": "^1.7.0",
     "mailchecker": "^6.0.17",
     "moment": "^2.30.1",