Implementing database class #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original
…end try/except exceptions related to the database with this logic, the database is accessed through a singleton that is initialized before running the server. If an exception is caught during a database operation, the value -1 is returned. Thus, whenever a database operation returns -1 in a server function, an error message is immediately returned with the error code 500. The error code and messages are the same everywhere by now but can be personnalized later on. server.py and tools.py have been modified following this logic and the return of every database call is checked. Also in the SAL and Connect4 functions in server.py, conditions have been added to redirect the user and log them out if their email happens to not be in the associated dictionnaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a database (DB) class that encapsulates all database operations end try/except exceptions related to the database
with this logic, the database is accessed through a singleton that is initialized before running the server. If an exception is caught during a database operation, the value -1 is returned.
Thus, whenever a database operation returns -1 in a server function, an error message is immediately returned with the error code 500. The error code and messages are the same everywhere by now but can be personnalized later on.
server.py and tools.py have been modified following this logic and the return of every database call is checked.
Also in the SAL and Connect4 functions in server.py, conditions have been added to redirect the user and log them out if their email happens to not be in the associated dictionnaries.