Skip to content

Commit ed2c291

Browse files
committed
docs: Add comment explaining ImageBytes/PdfBytes exclusion
Add clarifying comment in type_map explaining why ImageBytes and PdfBytes are not included in the dbt type mapping. While these types exist in Feast, dbt manifests only expose generic BYTES type without semantic information to distinguish between regular bytes, images, or PDFs. Example: A dbt model with image and PDF columns both appear as 'BYTES' in the manifest, making ImageBytes/PdfBytes types unmappable from dbt artifacts. Addresses feedback from PR feast-dev#5827 review (franciscojavierarceo). Signed-off-by: yassinnouh21 <[email protected]>
1 parent fe253c1 commit ed2c291

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

sdk/python/feast/dbt/codegen.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,9 @@ def _get_feast_type_name(feast_type: Any) -> str:
140140
base_type_name = _get_feast_type_name(base_type)
141141
return f"Array({base_type_name})"
142142

143-
# Map type objects to their names
143+
# Map type objects to their names.
144+
# Note: ImageBytes and PdfBytes are excluded since dbt manifests only expose
145+
# generic BYTES type without semantic information about binary content.
144146
type_map = {
145147
String: "String",
146148
Int32: "Int32",

0 commit comments

Comments
 (0)