Skip to content

Commit 5f694ed

Browse files
committed
Correct wrong mapping of types in json meta
1 parent f6d48e2 commit 5f694ed

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

query-engine/docs/query-engine-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ services:
5050
- 16686:16686
5151

5252
query-engine:
53-
image: ghcr.io/yaytay/query-engine-design-mode:0.0.66-main
53+
image: ghcr.io/yaytay/query-engine-design-mode:0.0.67-main
5454
ports:
5555
- 2000:8080
5656
volumes:

query-engine/src/main/java/uk/co/spudsoft/query/exec/fmts/json/FormatJsonInstance.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ private Future<Void> start() {
211211
if (cd.type() == DataType.Boolean) {
212212
typeName = "bool";
213213
} else if (cd.type() == DataType.Integer || cd.type() == DataType.Long) {
214-
typeName = "bool";
214+
typeName = "int";
215215
} else {
216216
typeName = typeName.toLowerCase(Locale.ROOT);
217217
}

query-engine/src/main/java/uk/co/spudsoft/query/exec/sources/sql/SourceSqlStreamingInstance.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ public Future<ReadStreamWithTypes> initialize(PipelineExecutor executor, Pipelin
142142
if (!JexlEvaluator.isNullOrBlank(endpoint.getCondition())) {
143143
ConditionInstance cond = endpoint.getCondition().createInstance();
144144
if (!cond.evaluate(requestContext, null)) {
145-
String message = String.format("Endpoint %s (%s) rejected by condition (%s)", definition.getEndpoint(), endpoint.getUrl(), endpoint.getCondition());
146-
logger.warn(message);
147-
return Future.failedFuture(new ServiceException(503, "Endpoint \"" + definition.getEndpoint() + "\" not accessible", new IllegalStateException(message)));
145+
String message = String.format("Endpoint %s (%s) rejected by condition (%s)", endpointName, endpoint.getUrl(), endpoint.getCondition());
146+
logger.warn("Endpoint {} ({}) rejected by condition ({})", endpointName, endpoint.getUrl(), endpoint.getCondition());
147+
return Future.failedFuture(new ServiceException(503, "Endpoint \"" + endpointName + "\" not accessible", new IllegalStateException(message)));
148148
}
149149
}
150150

query-engine/src/main/java/uk/co/spudsoft/query/main/Version.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public final class Version {
3434
/**
3535
* The project version, as set in the Maven pom.xml.
3636
*/
37-
public static final String MAVEN_PROJECT_VERSION = "0.0.66-main";
37+
public static final String MAVEN_PROJECT_VERSION = "0.0.67-main";
3838

3939
private Version() {
4040
}

query-engine/src/test/java/uk/co/spudsoft/query/main/FeatureRichQueryIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public void testQuery() throws Exception {
140140
.statusCode(200)
141141
.extract().body().asString();
142142

143-
assertThat(body, startsWith("{\"meta\":{\"description\":\"A complex pipeline that tries to demonstrate as many features as I can cram into a single pipeline.\",\"fields\":{\"dataId\":\"bool\",\"instant\":\"datetime\",\"colour\":\"string\",\"value\":\"string\",\"children\":\"string\",\"DateField\":\"date\",\"TimeField\":\"time\",\"DateTimeField\":\"datetime\",\"LongField\":\"bool\",\"DoubleField\":\"double\",\"BoolField\":\"bool\",\"TextField\":\"string\",\"child2\":\"string\",\"child3\":\"string\",\"child5\":\"string\",\"child4\":\"string\"}},\"data\":[{\"dataId\":1,\"instant\":\"1971-05-07T03:00:00Z\",\"colour\":\"antiquewhite\",\"value\":\"first\",\"children\":\"one\",\"DateField\":\"2023-05-05\",\"TimeField\":null,\"DateTimeField\":null,\"LongField\":null,\"DoubleField\":null,\"BoolField\":null,\"TextField\":null,\"child2\":\"one\",\"child3\":\"one\",\"child5\":\"one\",\"child4\":\"b0f56ab83929aeda\"},"));
143+
assertThat(body, startsWith("{\"meta\":{\"description\":\"A complex pipeline that tries to demonstrate as many features as I can cram into a single pipeline.\",\"fields\":{\"dataId\":\"int\",\"instant\":\"datetime\",\"colour\":\"string\",\"value\":\"string\",\"children\":\"string\",\"DateField\":\"date\",\"TimeField\":\"time\",\"DateTimeField\":\"datetime\",\"LongField\":\"int\",\"DoubleField\":\"double\",\"BoolField\":\"bool\",\"TextField\":\"string\",\"child2\":\"string\",\"child3\":\"string\",\"child5\":\"string\",\"child4\":\"string\"}},\"data\":[{\"dataId\":1,\"instant\":\"1971-05-07T03:00:00Z\",\"colour\":\"antiquewhite\",\"value\":\"first\",\"children\":\"one\",\"DateField\":\"2023-05-05\",\"TimeField\":null,\"DateTimeField\":null,\"LongField\":null,\"DoubleField\":null,\"BoolField\":null,\"TextField\":null,\"child2\":\"one\",\"child3\":\"one\",\"child5\":\"one\",\"child4\":\"b0f56ab83929aeda\"},"));
144144

145145
body = given()
146146
.queryParam("minDate", "2971-05-06")

query-engine/src/test/java/uk/co/spudsoft/query/main/MainQueryIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public void testQuery() throws Exception {
210210
.statusCode(200)
211211
.extract().body().asString();
212212

213-
assertThat(body, startsWith("{\"meta\":{\"fields\":{\"dataId\":\"bool\",\"ref\":\"string\",\"value\":\"string\",\"children\":\"string\"}},\"data\":[{\"dataId\":1,\"instant\":\"1971-05-07 03:00:00\",\"ref\":\"antiquewhite\",\"value\":\"first\",\"children\":\"one\"},"));
213+
assertThat(body, startsWith("{\"meta\":{\"fields\":{\"dataId\":\"int\",\"ref\":\"string\",\"value\":\"string\",\"children\":\"string\"}},\"data\":[{\"dataId\":1,\"instant\":\"1971-05-07 03:00:00\",\"ref\":\"antiquewhite\",\"value\":\"first\",\"children\":\"one\"},"));
214214
assertThat(body, endsWith(",{\"dataId\":13,\"instant\":\"1971-05-20 15:00:00\",\"ref\":\"cadetblue\",\"value\":\"thirteenth\",\"children\":\"thirteen,twenty six,thirty nine,fifty two,sixty five,seventy eight\"}]}"));
215215

216216
body = given()

0 commit comments

Comments
 (0)