Skip to content

Commit de7e566

Browse files
committed
Slight robustness tweak to ReadStreamToList
1 parent 35a587d commit de7e566

File tree

4 files changed

+14
-8
lines changed

4 files changed

+14
-8
lines changed

query-engine/docs/query-engine-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ services:
5050
- 16686:16686
5151

5252
query-engine:
53-
image: ghcr.io/yaytay/query-engine-design-mode:0.0.64-main
53+
image: ghcr.io/yaytay/query-engine-design-mode:0.0.64-1-main
5454
ports:
5555
- 2000:8080
5656
volumes:

query-engine/src/main/java/uk/co/spudsoft/query/exec/fmts/ReadStreamToList.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,17 @@ public static <T, U> Future<List<U>> map(ReadStream<T> input, Function<T, U> map
6262
List<U> collected = new ArrayList<>();
6363

6464
input.endHandler(v -> {
65-
promise.complete(collected);
65+
promise.tryComplete(collected);
6666
}).exceptionHandler(ex -> {
67-
promise.fail(ex);
67+
logger.warn("Exception capturing stream: {}", ex);
68+
promise.tryFail(ex);
6869
}).handler(item -> {
69-
collected.add(mapper.apply(item));
70+
try {
71+
U value = mapper.apply(item);
72+
collected.add(value);
73+
} catch (Throwable ex) {
74+
logger.warn("Failed to map value ({}): ", item, ex);
75+
}
7076
});
7177

7278
input.resume();
@@ -87,9 +93,9 @@ public static <T> Future<List<T>> captureByBatch(ReadStream<T> input, int initia
8793
List<T> collected = new ArrayList<>();
8894

8995
input.endHandler(v -> {
90-
promise.complete(collected);
96+
promise.tryComplete(collected);
9197
}).exceptionHandler(ex -> {
92-
promise.fail(ex);
98+
promise.tryFail(ex);
9399
}).handler(item -> {
94100
logger.debug("Got item: {}", item);
95101
collected.add(item);

query-engine/src/main/java/uk/co/spudsoft/query/exec/fmts/json/FormatJsonInstance.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ private Future<Void> start() {
210210
if (defn.isCompatibleTypeNames()) {
211211
if (cd.type() == DataType.Boolean) {
212212
typeName = "bool";
213-
} if (cd.type() == DataType.Integer || cd.type() == DataType.Long) {
213+
} else if (cd.type() == DataType.Integer || cd.type() == DataType.Long) {
214214
typeName = "bool";
215215
} else {
216216
typeName = typeName.toLowerCase(Locale.ROOT);

query-engine/src/main/java/uk/co/spudsoft/query/main/Version.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public final class Version {
3434
/**
3535
* The project version, as set in the Maven pom.xml.
3636
*/
37-
public static final String MAVEN_PROJECT_VERSION = "0.0.64-main";
37+
public static final String MAVEN_PROJECT_VERSION = "0.0.64-1-main";
3838

3939
private Version() {
4040
}

0 commit comments

Comments
 (0)