Skip to content

Commit c8dad84

Browse files
committed
Centralize all default configuration
1 parent 9742007 commit c8dad84

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

gradle-plugin/plugin/src/main/java/com/yelp/codegen/plugin/GenerateTask.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,6 @@ import org.gradle.api.tasks.OutputDirectory
1515
import org.gradle.api.tasks.TaskAction
1616
import org.gradle.api.tasks.options.Option
1717

18-
const val DEFAULT_PLATFORM = "kotlin"
19-
const val DEFAULT_VERSION = "0.0.0"
20-
const val DEFAULT_NAME = "defaultname"
21-
const val DEFAULT_PACKAGE = "com.codegen.default"
22-
const val DEFAULT_OUTPUT_DIR = "/gen"
23-
2418
abstract class GenerateTask : DefaultTask() {
2519

2620
init {

gradle-plugin/plugin/src/main/java/com/yelp/codegen/plugin/GenerateTaskConfiguration.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ abstract class GenerateTaskConfiguration @Inject constructor(project: Project) {
1717
val specVersion = objects.property(String::class.java).convention(project.provider {
1818
readVersionFromSpecfile(inputFile.get().asFile)
1919
})
20-
val outputDir = objects.directoryProperty().convention(project.layout.buildDirectory.dir(DEFAULT_OUTPUT_DIR).get())
20+
val outputDir = objects.directoryProperty().convention(project.layout.buildDirectory.dir("gen").get())
2121

2222
val extraFiles = objects.directoryProperty()
2323
val features: FeatureConfiguration = FeatureConfiguration(objects)

0 commit comments

Comments
 (0)