Configuration of inputFile via command line flags is not working

[astuetz]

I'm trying to specify the inputFile via command line options, as described inside the readme:

./gradlew generateSwagger --inputFile=./specs.json

but this fails with

Option 'inputFile' cannot be cast to type 'java.io.File' in class 'com.yelp.codegen.plugin.GenerateTask'.

I tried many different options of specifying the inputFile parameter, without any success.

After playing around with some custom task and @InputFile / @Option myself, it seems like it would only work if the type is a String (and not a RegularFileProperty). This would be in line with what the Gradle documentation about Option is saying:

https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/options/Option.html

An option may have one of the following types:

• boolean
• Boolean
• Property<Boolean>
• an enum type
• Property<T> of an enum type
• String
• Property<String>
• List<T> of an enum type
• List<String>

I didn't try any other properties, but maybe outputDir could also make problems, as it's a DirectoryProperty.

Plugin version: 1.4.1

[cortinico]

Thanks for reporting this @astuetz. You're right in the sense that this is broken. I think we should go for something like:

    @get:Input
    @get:Optional
    @get:Option(option = "inputPath", description = "Configures path of the Swagger Spec.")
    abstract val inputPath: Property<String>
    
    @get:InputFile
    abstract val inputFile: RegularFileProperty

And check which of the two is present, giving priority to inputPath and falling back to inputFile. The outputDir is also affected by this.

Happy to review a PR that fixes this 👍