fix: system backup history queries use wrong column names (#2421)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Yeraze

src/server/services/systemBackupService.ts

@@ -234,7 +234,7 @@ class SystemBackupService {
       if (!pool) throw new Error('PostgreSQL pool not initialized');
       await pool.query(
         `INSERT INTO system_backup_history
-         (dirname, timestamp, type, size, table_count, meshmonitor_version, schema_version, "createdAt")
+         ("backupPath", timestamp, "backupType", "totalSize", "tableCount", "appVersion", "schemaVersion", "createdAt")
          VALUES ($1, $2, $3, $4, $5, $6, $7, $8)`,
         [dirname, timestamp, type, size, tableCount, meshmonitorVersion, schemaVersion, Date.now()]
       );
@@ -243,15 +243,15 @@ class SystemBackupService {
       if (!pool) throw new Error('MySQL pool not initialized');
       await pool.execute(
         `INSERT INTO system_backup_history
-         (dirname, timestamp, type, size, table_count, meshmonitor_version, schema_version, createdAt)
+         (backupPath, timestamp, backupType, totalSize, tableCount, appVersion, schemaVersion, createdAt)
          VALUES (?, ?, ?, ?, ?, ?, ?, ?)`,
         [dirname, timestamp, type, size, tableCount, meshmonitorVersion, schemaVersion, Date.now()]
       );
     } else {
       const db = databaseService.db;
       const stmt = db.prepare(`
         INSERT INTO system_backup_history
-        (dirname, timestamp, type, size, table_count, meshmonitor_version, schema_version, createdAt)
+        (backupPath, timestamp, backupType, totalSize, tableCount, appVersion, schemaVersion, createdAt)
         VALUES (?, ?, ?, ?, ?, ?, ?, ?)
       `);
       stmt.run(dirname, timestamp, type, size, tableCount, meshmonitorVersion, schemaVersion, Date.now());
@@ -468,10 +468,11 @@ class SystemBackupService {
       const backupPath = path.join(SYSTEM_BACKUP_DIR, dirname);
 
       // Check if backup exists either in database or on disk
+      const bpCol = dbType === 'postgres' ? '"backupPath"' : 'backupPath';
       const row = await this.queryOne(
         dbType === 'postgres'
-          ? 'SELECT dirname FROM system_backup_history WHERE dirname = $1'
-          : 'SELECT dirname FROM system_backup_history WHERE dirname = ?',
+          ? `SELECT ${bpCol} FROM system_backup_history WHERE ${bpCol} = $1`
+          : `SELECT ${bpCol} FROM system_backup_history WHERE ${bpCol} = ?`,
         [dirname]
       );
 
@@ -490,8 +491,8 @@ class SystemBackupService {
       if (row) {
         await this.executeStatement(
           dbType === 'postgres'
-            ? 'DELETE FROM system_backup_history WHERE dirname = $1'
-            : 'DELETE FROM system_backup_history WHERE dirname = ?',
+            ? `DELETE FROM system_backup_history WHERE ${bpCol} = $1`
+            : `DELETE FROM system_backup_history WHERE ${bpCol} = ?`,
           [dirname]
         );
       }
@@ -531,31 +532,32 @@ class SystemBackupService {
 
       // Get oldest backups to delete
       const toDelete = totalBackups - limit;
+      const bpCol = dbType === 'postgres' ? '"backupPath"' : 'backupPath';
       const oldBackups = await this.queryRows(
         dbType === 'postgres'
-          ? 'SELECT dirname FROM system_backup_history ORDER BY timestamp ASC LIMIT $1'
-          : 'SELECT dirname FROM system_backup_history ORDER BY timestamp ASC LIMIT ?',
+          ? `SELECT ${bpCol} FROM system_backup_history ORDER BY timestamp ASC LIMIT $1`
+          : `SELECT ${bpCol} FROM system_backup_history ORDER BY timestamp ASC LIMIT ?`,
         [toDelete]
       );
 
       logger.info(`🧹 Purging ${oldBackups.length} old system backups (max: ${limit})...`);
 
       for (const backup of oldBackups) {
         // Delete directory from disk
-        const backupPath = path.join(SYSTEM_BACKUP_DIR, backup.dirname);
+        const backupPath = path.join(SYSTEM_BACKUP_DIR, backup.backupPath);
         if (fs.existsSync(backupPath)) {
           fs.rmSync(backupPath, { recursive: true, force: true });
         }
 
         // Delete from database
         await this.executeStatement(
           dbType === 'postgres'
-            ? 'DELETE FROM system_backup_history WHERE dirname = $1'
-            : 'DELETE FROM system_backup_history WHERE dirname = ?',
-          [backup.dirname]
+            ? `DELETE FROM system_backup_history WHERE ${bpCol} = $1`
+            : `DELETE FROM system_backup_history WHERE ${bpCol} = ?`,
+          [backup.backupPath]
         );
 
-        logger.debug(`  🗑️  Purged: ${backup.dirname}`);
+        logger.debug(`  🗑️  Purged: ${backup.backupPath}`);
       }
 
       logger.info(`✅ Purged ${oldBackups.length} old system backups`);