fix: use bulk query for getAllNodes to prevent PG pool exhaustion (#2404)

* fix: use bulk query for getAllNodes to prevent PG pool exhaustion

Two callers in server.ts used meshtasticManager.getAllNodes() which fires
one telemetry query per node via Promise.all. With 216+ nodes this
saturates the PostgreSQL connection pool (default 10), causing timeouts.

Switch to getAllNodesAsync() which uses a single bulk query for all
node uptimes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor: remove N+1 getAllNodes method, keep only bulk getAllNodesAsync

Remove the old getAllNodes() that fired one telemetry query per node.
Update test mocks to use getAllNodesAsync.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Yeraze

src/server/meshtasticManager.ts

@@ -10870,14 +10870,6 @@ class MeshtasticManager {
     return dbNodes.map(node => this.mapDbNodeToDeviceInfo(node, uptimeMap.get(node.nodeId)));
   }
 
-  // Get data from database instead of maintaining in-memory state
-  async getAllNodes(): Promise<DeviceInfo[]> {
-    const dbNodes = await databaseService.nodes.getAllNodes();
-    return await Promise.all(dbNodes.map(async node => {
-      const uptimeTelemetry = await databaseService.telemetry.getLatestTelemetryForType(node.nodeId, 'uptimeSeconds');
-      return this.mapDbNodeToDeviceInfo(node, uptimeTelemetry?.value);
-    }));
-  }
 
   // Shared mapping logic for converting a DB node to DeviceInfo
   private mapDbNodeToDeviceInfo(node: any, uptimeSeconds?: number): DeviceInfo {

src/server/server.estimatedposition.test.ts

@@ -11,7 +11,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
     };
 
     meshtasticManager = {
-      getAllNodes: vi.fn()
+      getAllNodesAsync: vi.fn()
     };
   });
 
@@ -28,7 +28,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
         position: null
       };
 
-      meshtasticManager.getAllNodes.mockReturnValue([nodeWithoutPosition]);
+      meshtasticManager.getAllNodesAsync.mockReturnValue([nodeWithoutPosition]);
 
       // Mock telemetry with estimated position
       databaseService.getTelemetryByNode.mockReturnValue([
@@ -55,7 +55,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
       ]);
 
       // Act - Simulate the enhancement logic from server.ts
-      const nodes = meshtasticManager.getAllNodes();
+      const nodes = meshtasticManager.getAllNodesAsync();
       const enhancedNodes = nodes.map((node: any) => {
         if (!node.user?.id) return { ...node, isMobile: false };
 
@@ -99,7 +99,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
         }
       };
 
-      meshtasticManager.getAllNodes.mockReturnValue([nodeWithPosition]);
+      meshtasticManager.getAllNodesAsync.mockReturnValue([nodeWithPosition]);
 
       // Mock telemetry with estimated position
       databaseService.getTelemetryByNode.mockReturnValue([
@@ -126,7 +126,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
       ]);
 
       // Act - Simulate the enhancement logic
-      const nodes = meshtasticManager.getAllNodes();
+      const nodes = meshtasticManager.getAllNodesAsync();
       const enhancedNodes = nodes.map((node: any) => {
         if (!node.user?.id) return { ...node, isMobile: false };
 
@@ -166,7 +166,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
         position: null
       };
 
-      meshtasticManager.getAllNodes.mockReturnValue([nodeWithoutPosition]);
+      meshtasticManager.getAllNodesAsync.mockReturnValue([nodeWithoutPosition]);
 
       // Mock telemetry without estimated position
       databaseService.getTelemetryByNode.mockReturnValue([
@@ -182,7 +182,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
       ]);
 
       // Act
-      const nodes = meshtasticManager.getAllNodes();
+      const nodes = meshtasticManager.getAllNodesAsync();
       const enhancedNodes = nodes.map((node: any) => {
         if (!node.user?.id) return { ...node, isMobile: false };
 
@@ -220,7 +220,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
         position: null
       };
 
-      meshtasticManager.getAllNodes.mockReturnValue([nodeWithoutPosition]);
+      meshtasticManager.getAllNodesAsync.mockReturnValue([nodeWithoutPosition]);
 
       // Mock telemetry with multiple estimated positions (most recent first)
       const now = Date.now();
@@ -268,7 +268,7 @@ describe('Server /api/nodes endpoint - Estimated Position Integration', () => {
       ]);
 
       // Act
-      const nodes = meshtasticManager.getAllNodes();
+      const nodes = meshtasticManager.getAllNodesAsync();
       const enhancedNodes = nodes.map((node: any) => {
         if (!node.user?.id) return { ...node, isMobile: false };
 

src/server/server.ts

@@ -836,7 +836,7 @@ setSettingsCallbacks({
  */
 apiRouter.get('/nodes', optionalAuth(), async (req, res) => {
   try {
-    const allNodes = await meshtasticManager.getAllNodes();
+    const allNodes = await meshtasticManager.getAllNodesAsync();
     const estimatedPositions = await databaseService.getAllNodesEstimatedPositionsAsync();
 
     // Filter nodes based on channel read permissions
@@ -2150,7 +2150,7 @@ apiRouter.get('/messages/unread-counts', optionalAuth(), async (req, res) => {
     // Get DM unread counts if user has messages permission (batch query)
     if (hasMessagesRead && localNodeInfo) {
       const allUnreadDMs = await databaseService.getBatchUnreadDMCountsAsync(localNodeInfo.nodeId, userId);
-      const allNodes = await meshtasticManager.getAllNodes();
+      const allNodes = await meshtasticManager.getAllNodesAsync();
       const visibleNodes = await filterNodesByChannelPermission(allNodes, req.user);
       const visibleNodeIds = new Set(visibleNodes.map(n => n.user?.id).filter(Boolean));
       const directMessages: { [nodeId: string]: number } = {};