fix: add missing audit_log columns for pre-3.7 SQLite databases by Yeraze · Pull Request #2361 · Yeraze/meshmonitor

Yeraze · 2026-03-21T20:59:55Z

Summary

Fixes SqliteError: table audit_log has no column named user_agent errors on pre-3.7 SQLite databases.

Root cause: Migration 012 added username to audit_log but missed ip_address and user_agent. The v3.7 baseline creates these columns for fresh installs, but databases that predate the baseline never got them. Drizzle ORM then fails when trying to insert audit log entries.

Fix: Migration 013 adds ip_address and user_agent columns to audit_log (idempotent — skips if already present). All three backends covered (SQLite, PostgreSQL, MySQL).

Files Changed

File	Change
`src/server/migrations/013_add_audit_log_missing_columns.ts`	New migration for all 3 backends
`src/db/migrations.ts`	Register migration 013
`src/db/migrations.test.ts`	Update registry count and last-migration assertions

Test plan

3044 tests pass, 0 failures
Migration is idempotent (duplicate column errors caught and skipped)
All three backends handled (SQLite, PostgreSQL, MySQL)

🤖 Generated with Claude Code

….7 databases Pre-3.7 SQLite databases may lack ip_address and user_agent columns on audit_log. Migration 012 added username but missed these two, causing "table audit_log has no column named user_agent" errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-21T21:20:05Z

Code Review Summary

Severity: HIGH - This migration contains several critical issues that could cause data corruption and schema inconsistencies.

🔴 Critical Issues Found

Column Name Mismatch Across Databases - The migration creates inconsistent schemas between SQLite and PostgreSQL/MySQL
Missing Column Handling - The migration doesn't account for value_before and value_after columns
Test Failure - The test file has an incorrect assertion that will fail

🟡 Implementation Issues

Inconsistent Error Handling - Different idempotency approaches across database backends
Incomplete Schema Documentation - Missing comprehensive column validation

✅ Positive Aspects

Good migration structure with proper backend separation
Comprehensive logging and error handling foundation
Proper idempotency consideration (though incorrectly implemented)

Detailed Findings

See inline comments for specific technical details and fix suggestions. The most critical issue is the column name mismatch that will break the Drizzle ORM when switching between database backends.

Recommendations

Fix column naming consistency to match the Drizzle schema expectations
Update test assertions to reflect the correct migration count
Add missing column handling for complete schema alignment
Standardize idempotency approaches across all database backends

This PR should not be merged until the critical column naming issues are resolved.

github-actions · 2026-03-21T21:20:12Z

src/server/migrations/013_add_audit_log_missing_columns.ts

+  logger.info('Running migration 013 (PostgreSQL): Ensuring audit_log columns exist...');
+
+  try {
+    await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS "ipAddress" TEXT');


🔴 Critical Issue: Column Name Mismatch

The PostgreSQL migration uses "ipAddress" (camelCase with quotes), but the Drizzle schema defines it as ipAddress (camelCase without quotes). This inconsistency will cause schema validation failures.

Suggested change

await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS "ipAddress" TEXT');

await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS ipAddress TEXT');

The Drizzle schema in src/db/schema/auth.ts:109 expects ipAddress without quotes.

github-actions · 2026-03-21T21:20:16Z

src/server/migrations/013_add_audit_log_missing_columns.ts

+
+  try {
+    await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS "ipAddress" TEXT');
+    await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS "userAgent" TEXT');


🔴 Critical Issue: Column Name Mismatch

Same issue as above - using quoted "userAgent" instead of unquoted userAgent to match the Drizzle schema.

Suggested change

await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS "userAgent" TEXT');

await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS userAgent TEXT');

github-actions · 2026-03-21T21:20:28Z

src/server/migrations/013_add_audit_log_missing_columns.ts

+    try {
+      db.exec('ALTER TABLE audit_log ADD COLUMN ip_address TEXT');
+      logger.debug('Added ip_address column to audit_log');
+    } catch (e: any) {
+      if (e.message?.includes('duplicate column')) {
+        logger.debug('audit_log.ip_address already exists, skipping');
+      } else {
+        logger.warn('Could not add ip_address to audit_log:', e.message);
+      }
+    }
+
+    // 2. Add user_agent to audit_log
+    try {
+      db.exec('ALTER TABLE audit_log ADD COLUMN user_agent TEXT');
+      logger.debug('Added user_agent column to audit_log');
+    } catch (e: any) {
+      if (e.message?.includes('duplicate column')) {
+        logger.debug('audit_log.user_agent already exists, skipping');
+      } else {
+        logger.warn('Could not add user_agent to audit_log:', e.message);
+      }
+    }


🟡 Incomplete Schema Alignment

The migration only adds ip_address and user_agent, but looking at the v3.7 baseline (lines 253-266 in 001_v37_baseline.ts), the SQLite audit_log table also includes:

value_before TEXT

value_after TEXT

These columns are missing from the Drizzle schema as well. For complete schema alignment across all database versions, this migration should also add these missing columns:

Suggested change

try {

db.exec('ALTER TABLE audit_log ADD COLUMN ip_address TEXT');

logger.debug('Added ip_address column to audit_log');

} catch (e: any) {

if (e.message?.includes('duplicate column')) {

logger.debug('audit_log.ip_address already exists, skipping');

} else {

logger.warn('Could not add ip_address to audit_log:', e.message);

}

}

// 2. Add user_agent to audit_log

try {

db.exec('ALTER TABLE audit_log ADD COLUMN user_agent TEXT');

logger.debug('Added user_agent column to audit_log');

} catch (e: any) {

if (e.message?.includes('duplicate column')) {

logger.debug('audit_log.user_agent already exists, skipping');

} else {

logger.warn('Could not add user_agent to audit_log:', e.message);

}

}

// 1. Add ip_address to audit_log

try {

db.exec('ALTER TABLE audit_log ADD COLUMN ip_address TEXT');

logger.debug('Added ip_address column to audit_log');

} catch (e: any) {

if (e.message?.includes('duplicate column')) {

logger.debug('audit_log.ip_address already exists, skipping');

} else {

logger.warn('Could not add ip_address to audit_log:', e.message);

}

}

// 2. Add user_agent to audit_log

try {

db.exec('ALTER TABLE audit_log ADD COLUMN user_agent TEXT');

logger.debug('Added user_agent column to audit_log');

} catch (e: any) {

if (e.message?.includes('duplicate column')) {

logger.debug('audit_log.user_agent already exists, skipping');

} else {

logger.warn('Could not add user_agent to audit_log:', e.message);

}

}

// 3. Add value_before to audit_log (if not exists)

try {

db.exec('ALTER TABLE audit_log ADD COLUMN value_before TEXT');

logger.debug('Added value_before column to audit_log');

} catch (e: any) {

if (e.message?.includes('duplicate column')) {

logger.debug('audit_log.value_before already exists, skipping');

} else {

logger.warn('Could not add value_before to audit_log:', e.message);

}

}

// 4. Add value_after to audit_log (if not exists)

try {

db.exec('ALTER TABLE audit_log ADD COLUMN value_after TEXT');

logger.debug('Added value_after column to audit_log');

} catch (e: any) {

if (e.message?.includes('duplicate column')) {

logger.debug('audit_log.value_after already exists, skipping');

} else {

logger.warn('Could not add value_after to audit_log:', e.message);

}

}

github-actions · 2026-03-21T21:20:35Z

src/server/migrations/013_add_audit_log_missing_columns.ts

+    const [ipRows] = await pool.query(`
+      SELECT COLUMN_NAME FROM information_schema.COLUMNS
+      WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = 'audit_log' AND COLUMN_NAME = 'ipAddress'
+    `);
+    if (!Array.isArray(ipRows) || ipRows.length === 0) {
+      await pool.query('ALTER TABLE audit_log ADD COLUMN ipAddress TEXT');
+      logger.debug('Added ipAddress to audit_log');
+    } else {
+      logger.debug('audit_log.ipAddress already exists, skipping');
+    }
+
+    const [uaRows] = await pool.query(`
+      SELECT COLUMN_NAME FROM information_schema.COLUMNS
+      WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = 'audit_log' AND COLUMN_NAME = 'userAgent'
+    `);
+    if (!Array.isArray(uaRows) || uaRows.length === 0) {
+      await pool.query('ALTER TABLE audit_log ADD COLUMN userAgent TEXT');
+      logger.debug('Added userAgent to audit_log');
+    } else {
+      logger.debug('audit_log.userAgent already exists, skipping');
+    }


🟡 Inconsistent Idempotency Approach

The MySQL implementation uses information_schema queries for idempotency, while PostgreSQL uses IF NOT EXISTS and SQLite uses try/catch. For consistency and performance, consider using MySQL's native IF NOT EXISTS syntax (available in MySQL 5.6+):

Suggested change

const [ipRows] = await pool.query(`

SELECT COLUMN_NAME FROM information_schema.COLUMNS

WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = 'audit_log' AND COLUMN_NAME = 'ipAddress'

`);

if (!Array.isArray(ipRows) || ipRows.length === 0) {

await pool.query('ALTER TABLE audit_log ADD COLUMN ipAddress TEXT');

logger.debug('Added ipAddress to audit_log');

} else {

logger.debug('audit_log.ipAddress already exists, skipping');

}

const [uaRows] = await pool.query(`

SELECT COLUMN_NAME FROM information_schema.COLUMNS

WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = 'audit_log' AND COLUMN_NAME = 'userAgent'

`);

if (!Array.isArray(uaRows) || uaRows.length === 0) {

await pool.query('ALTER TABLE audit_log ADD COLUMN userAgent TEXT');

logger.debug('Added userAgent to audit_log');

} else {

logger.debug('audit_log.userAgent already exists, skipping');

}

try {

await pool.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS ipAddress TEXT');

logger.debug('Ensured ipAddress exists on audit_log');

await pool.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS userAgent TEXT');

logger.debug('Ensured userAgent exists on audit_log');

} catch (error: any) {

logger.error('Migration 013 (MySQL) failed:', error.message);

throw error;

}

This approach is more efficient and matches the PostgreSQL pattern.

github-actions · 2026-03-21T21:20:40Z

src/db/migrations.test.ts

+    expect(last.name).toContain('audit_log');
  });

  it('migrations are sequentially numbered from 1 to 12', () => {


🔴 Test Will Fail

This assertion is incorrect. The test expects migrations numbered 1 to 12, but with the addition of migration 013, we now have 13 migrations numbered 1 to 13.

Suggested change

it('migrations are sequentially numbered from 1 to 12', () => {

it('migrations are sequentially numbered from 1 to 13', () => {

github-actions bot reviewed Mar 21, 2026

View reviewed changes

Yeraze merged commit 6c9d84a into main Mar 21, 2026
17 of 18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add missing audit_log columns for pre-3.7 SQLite databases#2361

fix: add missing audit_log columns for pre-3.7 SQLite databases#2361
Yeraze merged 1 commit intomainfrom
fix/audit-log-missing-columns

Yeraze commented Mar 21, 2026

Uh oh!

github-actions bot commented Mar 21, 2026

Uh oh!

github-actions bot Mar 21, 2026

Uh oh!

github-actions bot Mar 21, 2026

Uh oh!

github-actions bot Mar 21, 2026

Uh oh!

github-actions bot Mar 21, 2026

Uh oh!

github-actions bot Mar 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS "ipAddress" TEXT');
	await client.query('ALTER TABLE audit_log ADD COLUMN IF NOT EXISTS ipAddress TEXT');

	it('migrations are sequentially numbered from 1 to 12', () => {
	it('migrations are sequentially numbered from 1 to 13', () => {

Uh oh!

Conversation

Yeraze commented Mar 21, 2026

Summary

Files Changed

Test plan

Uh oh!

github-actions bot commented Mar 21, 2026

Code Review Summary

🔴 Critical Issues Found

🟡 Implementation Issues

✅ Positive Aspects

Detailed Findings

Recommendations

Uh oh!

github-actions bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant