Skip to content

Commit d1d15ce

Browse files
YixingZhang007YixingZhang007
committed
[Backport to 15] Implement SPV_INTEL_predicated_io extension (KhronosGroup#3370)
This extension adds predicated load and store instructions. Predicated load performs load from memory if predicate is true; otherwise, it uses default_value as a result. Predicated store performs store of value to memory if predicate is true; otherwise, it does nothing. Spec: intel/llvm#20158 Signed-off-by: Zhang, Yixing <yixing.zhang@intel.com>
1 parent 752e3f3 commit d1d15ce

File tree

6 files changed

+106
-0
lines changed

6 files changed

+106
-0
lines changed

‎include/LLVMSPIRVExtensions.inc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,3 +79,4 @@ EXT(SPV_INTEL_ternary_bitwise_function)
7979
EXT(SPV_INTEL_int4)
8080
EXT(SPV_INTEL_function_variants)
8181
EXT(SPV_INTEL_shader_atomic_bfloat16)
82+
EXT(SPV_INTEL_predicated_io)

‎lib/SPIRV/libSPIRV/SPIRVInstruction.h‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4101,5 +4101,22 @@ class SPIRVTernaryBitwiseFunctionINTELInst : public SPIRVInstTemplateBase {
41014101
_SPIRV_OP(BitwiseFunction, true, 7)
41024102
#undef _SPIRV_OP
41034103

4104+
class SPIRVPredicatedIOINTELInst : public SPIRVInstTemplateBase {
4105+
public:
4106+
std::optional<ExtensionID> getRequiredExtension() const override {
4107+
return ExtensionID::SPV_INTEL_predicated_io;
4108+
}
4109+
SPIRVCapVec getRequiredCapability() const override {
4110+
return getVec(internal::CapabilityPredicatedIOINTEL);
4111+
}
4112+
};
4113+
4114+
#define _SPIRV_OP(x, ...) \
4115+
typedef SPIRVInstTemplate<SPIRVPredicatedIOINTELInst, \
4116+
internal::Op##x##INTEL, __VA_ARGS__> \
4117+
SPIRV##x##INTEL;
4118+
_SPIRV_OP(PredicatedLoad, true, 6, true)
4119+
_SPIRV_OP(PredicatedStore, false, 4, true)
4120+
#undef _SPIRV_OP
41044121
} // namespace SPIRV
41054122
#endif // SPIRV_LIBSPIRV_SPIRVINSTRUCTION_H

‎lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,7 @@ template <> inline void SPIRVMap<Capability, std::string>::init() {
655655
add(CapabilityFunctionVariantsINTEL, "FunctionVariantsINTEL");
656656
add(CapabilitySpecConditionalINTEL, "SpecConditionalINTEL");
657657
add(internal::CapabilityBFloat16ArithmeticINTEL, "BFloat16ArithmeticINTEL");
658+
add(internal::CapabilityPredicatedIOINTEL, "PredicatedIOINTEL");
658659
}
659660
SPIRV_DEF_NAMEMAP(Capability, SPIRVCapabilityNameMap)
660661

‎lib/SPIRV/libSPIRV/SPIRVOpCodeEnumInternal.h‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,7 @@ _SPIRV_OP_INTERNAL(ConvertHandleToSamplerINTEL,
3434
internal::ConvertHandleToSamplerINTEL)
3535
_SPIRV_OP_INTERNAL(ConvertHandleToSampledImageINTEL,
3636
internal::ConvertHandleToSampledImageINTEL)
37+
_SPIRV_OP_INTERNAL(PredicatedLoadINTEL,
38+
internal::OpPredicatedLoadINTEL)
39+
_SPIRV_OP_INTERNAL(PredicatedStoreINTEL,
40+
internal::OpPredicatedStoreINTEL)

‎lib/SPIRV/libSPIRV/spirv_internal.hpp‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ enum InternalOp {
7171
IOpCooperativeMatrixLoadCheckedINTEL = 6193,
7272
IOpCooperativeMatrixStoreCheckedINTEL = 6194,
7373
IOpCooperativeMatrixConstructCheckedINTEL = 6195,
74+
IOpPredicatedLoadINTEL = 6258,
75+
IOpPredicatedStoreINTEL = 6259,
7476
IOpJointMatrixWorkItemLengthINTEL = 6410,
7577
IOpComplexFMulINTEL = 6415,
7678
IOpComplexFDivINTEL = 6416,
@@ -112,6 +114,7 @@ enum InternalCapability {
112114
ICapabilityBFloat16ArithmeticINTEL = 6226,
113115
ICapabilityAtomicBFloat16AddINTEL = 6255,
114116
ICapabilityAtomicBFloat16MinMaxINTEL = 6256,
117+
ICapabilityPredicatedIOINTEL = 6257,
115118
ICapabilityCooperativeMatrixPrefetchINTEL = 6411,
116119
ICapabilityComplexFloatMulDivINTEL = 6414,
117120
ICapabilityTensorFloat32RoundingINTEL = 6425,
@@ -187,6 +190,11 @@ _SPIRV_OP(Op, ConvertHandleToSampledImageINTEL)
187190

188191
_SPIRV_OP(Capability, AtomicBFloat16AddINTEL)
189192
_SPIRV_OP(Capability, AtomicBFloat16MinMaxINTEL)
193+
194+
_SPIRV_OP(Capability, PredicatedIOINTEL)
195+
_SPIRV_OP(Op, PredicatedLoadINTEL)
196+
_SPIRV_OP(Op, PredicatedStoreINTEL)
197+
190198
#undef _SPIRV_OP
191199

192200
constexpr SourceLanguage SourceLanguagePython =

‎test/extensions/INTEL/SPV_INTEL_predicated_io/predicated_io_generic.ll‎

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
; Generated with:
2+
; source.cl:
3+
; int __spirv_PredicatedLoadINTEL(const __global int* pointer, bool predicate, int default_value);
4+
; int __spirv_PredicatedLoadINTEL(const __global int* pointer, bool predicate, int default_value, int memory_operands);
5+
; void __spirv_PredicatedStoreINTEL(const __global int* pointer, int object, bool predicate);
6+
; void __spirv_PredicatedStoreINTEL(const __global int* pointer, int object, bool predicate, int memory_operands);
7+
;
8+
; void foo(const __global int* load_pointer, __global int* store_pointer, int default_value, int store_object, bool predicate) {
9+
; const int memory_ops = 0;
10+
; int result1 = __spirv_PredicatedLoadINTEL(load_pointer, predicate, default_value);
11+
; int result2 = __spirv_PredicatedLoadINTEL(load_pointer, predicate, default_value, memory_ops);
12+
; __spirv_PredicatedStoreINTEL(store_pointer, store_object, predicate);
13+
; __spirv_PredicatedStoreINTEL(store_pointer, store_object, predicate, memory_ops);
14+
; }
15+
; clang -cc1 -cl-std=clc++2021 -triple spir64-unknown-unknown -emit-llvm -finclude-default-header source.cl -o tmp.ll
16+
17+
; RUN: llvm-as %s -o %t.bc
18+
; RUN: llvm-spirv %t.bc -o %t.spv --spirv-ext=+SPV_INTEL_predicated_io
19+
; RUN: llvm-spirv %t.spv -o %t.spt --to-text
20+
; RUN: FileCheck < %t.spt %s --check-prefix=CHECK-SPIRV
21+
22+
; RUN: llvm-spirv %t.spv -o %t.rev.bc -r --spirv-target-env=SPV-IR
23+
; RUN: llvm-dis %t.rev.bc -o %t.rev.ll
24+
; RUN: FileCheck < %t.rev.ll %s --check-prefix=CHECK-LLVM
25+
26+
; RUN: not llvm-spirv %t.bc 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR
27+
; CHECK-ERROR: RequiresExtension: Feature requires the following SPIR-V extension:
28+
; CHECK-ERROR-NEXT: SPV_INTEL_predicated_io
29+
30+
; CHECK-SPIRV: Capability PredicatedIOINTEL
31+
; CHECK-SPIRV: Extension "SPV_INTEL_predicated_io"
32+
; CHECK-SPIRV-DAG: TypeInt [[#Int32Ty:]] 32 0
33+
; CHECK-SPIRV-DAG: Constant [[#Int32Ty]] [[#Const0:]] 0
34+
; CHECK-SPIRV-DAG: TypeVoid [[#VoidTy:]]
35+
; CHECK-SPIRV-DAG: TypePointer [[#IntPtrTy:]] 5 [[#Int32Ty]]
36+
; CHECK-SPIRV-DAG: TypeBool [[#BoolTy:]]
37+
; CHECK-SPIRV: FunctionParameter [[#IntPtrTy]] [[#LoadPtr:]]
38+
; CHECK-SPIRV: FunctionParameter [[#IntPtrTy]] [[#StorePtr:]]
39+
; CHECK-SPIRV: FunctionParameter [[#Int32Ty]] [[#DefaultVal:]]
40+
; CHECK-SPIRV: FunctionParameter [[#Int32Ty]] [[#StoreObj:]]
41+
; CHECK-SPIRV: FunctionParameter [[#BoolTy]] [[#Predicate:]]
42+
; CHECK-SPIRV: PredicatedLoadINTEL [[#Int32Ty]] [[#Result1:]] [[#LoadPtr]] [[#Predicate]] [[#DefaultVal]]
43+
; CHECK-SPIRV: PredicatedLoadINTEL [[#Int32Ty]] [[#Result2:]] [[#LoadPtr]] [[#Predicate]] [[#DefaultVal]] [[#Const0]]
44+
; CHECK-SPIRV: PredicatedStoreINTEL [[#StorePtr]] [[#StoreObj]] [[#Predicate]]
45+
; CHECK-SPIRV: PredicatedStoreINTEL [[#StorePtr]] [[#StoreObj]] [[#Predicate]] [[#Const0]]
46+
47+
; CHECK-LLVM: call spir_func i32 @_Z27__spirv_PredicatedLoadINTELPU3AS1ibi(ptr addrspace(1) %{{.*}}, i1 %{{.*}}, i32 %{{.*}})
48+
; CHECK-LLVM: call spir_func i32 @_Z27__spirv_PredicatedLoadINTELPU3AS1ibii(ptr addrspace(1) %{{.*}}, i1 %{{.*}}, i32 %{{.*}}, i32 0)
49+
; CHECK-LLVM: call spir_func void @_Z28__spirv_PredicatedStoreINTELPU3AS1iib(ptr addrspace(1) %{{.*}}, i32 %{{.*}}, i1 %{{.*}})
50+
; CHECK-LLVM: call spir_func void @_Z28__spirv_PredicatedStoreINTELPU3AS1iibi(ptr addrspace(1) %{{.*}}, i32 %{{.*}}, i1 %{{.*}}, i32 0)
51+
52+
target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
53+
target triple = "spir64-unknown-unknown"
54+
55+
define spir_func void @foo(ptr addrspace(1) %load_pointer, ptr addrspace(1) %store_pointer, i32 %default_value, i32 %store_object, i1 zeroext %predicate) {
56+
entry:
57+
%1 = call spir_func i32 @_Z27__spirv_PredicatedLoadINTELPU3AS1Kibi(ptr addrspace(1) %load_pointer, i1 %predicate, i32 %default_value)
58+
%2 = call spir_func i32 @_Z27__spirv_PredicatedLoadINTELPU3AS1Kibii(ptr addrspace(1) %load_pointer, i1 %predicate, i32 %default_value, i32 0)
59+
call spir_func void @_Z28__spirv_PredicatedStoreINTELPU3AS1Kiib(ptr addrspace(1) %store_pointer, i32 %store_object, i1 %predicate)
60+
call spir_func void @_Z28__spirv_PredicatedStoreINTELPU3AS1Kiibi(ptr addrspace(1) %store_pointer, i32 %store_object, i1 %predicate, i32 0)
61+
ret void
62+
}
63+
64+
declare spir_func i32 @_Z27__spirv_PredicatedLoadINTELPU3AS1Kibi(ptr addrspace(1), i1, i32)
65+
declare spir_func i32 @_Z27__spirv_PredicatedLoadINTELPU3AS1Kibii(ptr addrspace(1), i1, i32, i32)
66+
declare spir_func void @_Z28__spirv_PredicatedStoreINTELPU3AS1Kiib(ptr addrspace(1), i32, i1)
67+
declare spir_func void @_Z28__spirv_PredicatedStoreINTELPU3AS1Kiibi(ptr addrspace(1), i32, i1, i32)
68+
69+
!opencl.spir.version = !{!0}
70+
!spirv.Source = !{!1}
71+
!llvm.ident = !{!2}
72+
73+
!0 = !{i32 1, i32 2}
74+
!1 = !{i32 4, i32 100000}
75+
!2 = !{!"clang version 17.0.0"}

0 commit comments

Comments
 (0)