Merge pull request #229 from Yoast/fix-welcome-notice

DUPP-217 Fix welcome notice

Author: karlijnbok

admin-functions.php

@@ -199,7 +199,7 @@ function duplicate_post_migrate_show_links_in_options( $defaults ) {
 }
 
 /**
- * Shows the update notice.
+ * Shows the welcome notice.
  *
  * @global string $wp_version The WordPress version string.
  */

src/admin/options.php

@@ -259,7 +259,7 @@ public function get_options() {
 			'duplicate_post_show_notice'                  => [
 				'tab'   => 'display',
 				'type'  => 'checkbox',
-				'label' => \__( 'Show update notice', 'duplicate-post' ),
+				'label' => \__( 'Show welcome notice', 'duplicate-post' ),
 				'value' => 1,
 			],
 			'duplicate_post_show_link'                    => [

src/admin/views/options.php

@@ -233,7 +233,7 @@ class="nav-tab"
 					</td>
 				</tr>
 				<tr>
-					<th scope="row"><?php \esc_html_e( 'Update notice', 'duplicate-post' ); ?></th>
+					<th scope="row"><?php \esc_html_e( 'Welcome notice', 'duplicate-post' ); ?></th>
 					<td>
 						<?php
 						// phpcs:ignore WordPress.Security.EscapeOutput -- Already escapes correctly.

src/ui/newsletter.php

@@ -34,7 +34,7 @@ public static function newsletter_signup_form() {
 				'Yoast respects your privacy. Read %1$sour privacy policy%2$s on how we handle your personal information.',
 				'duplicate-post'
 			),
-			'<a href=https://yoa.st/4jf">',
+			'<a href="https://yoa.st/4jf" target="_blank">',
 			'</a>'
 		);