Throw Error on failing file_get_contents($plugin->getConf('openidurl')); (#6)

fjf2002 · web-flow · commit c7829faae41c · 2023-08-17T00:34:30.000+09:00
It took me quite a while to debug. Finally it was a proxy issue.

But please to not silence errors and continue execution. Throw the errors. Thank you.
diff --git a/Keycloak.php b/Keycloak.php
@@ -41,7 +41,7 @@ public function getEndpoint(string $endpoint)
         if (!isset($this->discovery)) {
             $plugin = plugin_load('helper', 'oauthkeycloak');
             $json = file_get_contents($plugin->getConf('openidurl'));
-            if (!$json) return '';
+            if (!$json) throw new \Exception('Failed accessing ' . $plugin->getConf('openidurl'));
             $this->discovery = json_decode($json, true);
         }
         if (!isset($this->discovery[$endpoint])) return '';

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function getEndpoint(string $endpoint)`
`41`	`41`	`if (!isset($this->discovery)) {`
`42`	`42`	`$plugin = plugin_load('helper', 'oauthkeycloak');`
`43`	`43`	`$json = file_get_contents($plugin->getConf('openidurl'));`
`44`		`- if (!$json) return '';`
	`44`	`+ if (!$json) throw new \Exception('Failed accessing ' . $plugin->getConf('openidurl'));`
`45`	`45`	`$this->discovery = json_decode($json, true);`
`46`	`46`	`}`
`47`	`47`	`if (!isset($this->discovery[$endpoint])) return '';`