Use Recommended analysis mode

Author: Youssef1313

.globalconfig

@@ -237,5 +237,11 @@ dotnet_diagnostic.CA1824.severity = none
 # CA1062: Validate arguments of public methods
 dotnet_diagnostic.CA1062.severity = none
 
+# CA1510: Use ArgumentNullException throw helper
+dotnet_diagnostic.CA1510.severity = none
+
+# CA1863: Use 'CompositeFormat'
+dotnet_diagnostic.CA1863.severity = none
+
 
 # TODO: Use YAnalyzers for var vs explicit types.

Directory.Build.props

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <UseArtifactsOutput>true</UseArtifactsOutput>
     <ArtifactsPath>$(MSBuildThisFileDirectory)artifacts</ArtifactsPath>
-    <AnalysisLevel>latest</AnalysisLevel>
+    <AnalysisLevel>latest-Recommended</AnalysisLevel>
     <LangVersion>preview</LangVersion>
     <Nullable>enable</Nullable>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>

src/YTest.MTP.XUnit2/Filter/FilterHelper.cs

@@ -15,37 +15,6 @@ internal static class FilterHelper
     private static readonly char[] s_specialCharacters = ['\\', '(', ')', '&', '|', '=', '!', '~'];
     private static readonly HashSet<char> s_specialCharactersSet = new(s_specialCharacters);
 
-    /// <summary>
-    /// Escapes a set of special characters for filter (%, (, ), &amp;, |, =, !, ~) by replacing them with their escape sequences.
-    /// </summary>
-    /// <param name="str">The input string that contains the text to convert.</param>
-    /// <returns>A string of characters with special characters converted to their escaped form.</returns>
-    public static string Escape(string str)
-    {
-        if (str is null)
-        {
-            throw new ArgumentNullException(nameof(str));
-        }
-
-        if (str.IndexOfAny(s_specialCharacters) < 0)
-        {
-            return str;
-        }
-
-        var builder = new StringBuilder();
-        for (int i = 0; i < str.Length; ++i)
-        {
-            var currentChar = str[i];
-            if (s_specialCharactersSet.Contains(currentChar))
-            {
-                builder.Append(EscapeCharacter);
-            }
-            builder.Append(currentChar);
-        }
-
-        return builder.ToString();
-    }
-
     /// <summary>
     /// Converts any escaped characters in the input filter string.
     /// </summary>

src/YTest.MTP.XUnit2/MTPFramework/Capabilities/BannerMessageOwnerCapability.cs

@@ -22,5 +22,5 @@ internal sealed class BannerMessageOwnerCapability : IBannerMessageOwnerCapabili
         ));
 
     private static string GetAssemblyVersion(Assembly assembly)
-        => ((AssemblyInformationalVersionAttribute?)assembly.GetCustomAttribute(typeof(AssemblyInformationalVersionAttribute)))?.InformationalVersion ?? "<unknown>";
+        => assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion ?? "<unknown>";
 }

src/YTest.MTP.XUnit2/MTPFramework/RunSettings.cs

@@ -7,7 +7,7 @@
 namespace YTest.MTP.XUnit2;
 
 // TODO: Look into NoAutoReporters and ReporterSwitch to see if they can be supported.
-internal class RunSettings
+internal sealed class RunSettings
 {
     public AppDomainSupport? AppDomain { get; set; }
     // public int? AssertEquivalentMaxDepth { get; set; }

src/YTest.MTP.XUnit2/MTPFramework/XUnit2MTPCommandLineProvider.cs

@@ -6,7 +6,7 @@
 
 namespace YTest.MTP.XUnit2;
 
-internal class XUnit2MTPCommandLineProvider : ICommandLineOptionsProvider
+internal sealed class XUnit2MTPCommandLineProvider : ICommandLineOptionsProvider
 {
     public const string FilterOptionName = "filter";
     public const string SettingsOptionName = "settings";