Setup Githun Action

Author: YuWei-CH

.github/workflows/ci.yml

@@ -0,0 +1,52 @@
+name: CI
+
+on:
+  push:
+  workflow_dispatch:
+
+jobs:
+  backend-tests:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: backend
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+          cache: pip
+          cache-dependency-path: |
+            backend/requirements.txt
+            backend/requirements-dev.txt
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install -r requirements.txt -r requirements-dev.txt
+      - name: Run tests
+        env:
+          DATABASE_URL: sqlite+pysqlite:///:memory:
+          ENABLE_GEOCODING: "0"
+        run: python -m pytest -q
+
+  frontend-build:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: frontend
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: npm
+          cache-dependency-path: frontend/package-lock.json
+      - name: Install dependencies
+        run: npm ci
+      - name: Build
+        run: npm run build
+

backend/tests/conftest.py

@@ -0,0 +1,22 @@
+import os
+import sys
+from pathlib import Path
+
+import pytest
+
+
+BACKEND_DIR = Path(__file__).resolve().parents[1]
+sys.path.insert(0, str(BACKEND_DIR))
+
+os.environ.setdefault("DATABASE_URL", "sqlite+pysqlite:///:memory:")
+os.environ.setdefault("ENABLE_GEOCODING", "0")
+
+
+@pytest.fixture(autouse=True)
+def _reset_db() -> None:
+    from app import models  # noqa: F401
+    from app.db import Base, engine
+
+    Base.metadata.drop_all(bind=engine)
+    Base.metadata.create_all(bind=engine)
+

backend/tests/test_distance.py

@@ -0,0 +1,12 @@
+from app.distance import haversine_km
+
+
+def test_haversine_zero_distance() -> None:
+    assert haversine_km(0.0, 0.0, 0.0, 0.0) == 0.0
+
+
+def test_haversine_small_delta_lat_reasonable() -> None:
+    # 0.001 degrees latitude is ~111 meters.
+    d = haversine_km(37.0, -122.0, 37.001, -122.0)
+    assert 0.09 < d < 0.14
+

backend/tests/test_geocoding_helpers.py

@@ -0,0 +1,14 @@
+from app.geocoding import approx_street_from_address, rough_location_from_address
+
+
+def test_rough_location_city_state() -> None:
+    assert rough_location_from_address({"city": "Sunnyvale", "state": "CA"}) == "Sunnyvale, CA"
+
+
+def test_rough_location_country_only() -> None:
+    assert rough_location_from_address({"country": "US"}) == "US"
+
+
+def test_approx_street_prefers_road() -> None:
+    assert approx_street_from_address({"road": "E Middlefield Rd"}) == "E Middlefield Rd"
+

backend/tests/test_targets_compare.py

@@ -0,0 +1,162 @@
+from fastapi.testclient import TestClient
+
+import app.main as main
+from app.distance import haversine_km
+from app.geocoding import GeocodeResult, ReverseGeocodeResult
+
+
+def test_geocode_endpoint_uses_provider(monkeypatch) -> None:
+    def fake_geocode_address(query: str, *, limit: int = 5) -> list[GeocodeResult]:
+        assert query.strip() == "Waymo"
+        assert limit == 1
+        return [GeocodeResult(display_name="Waymo HQ", lat=37.416, lng=-122.077)]
+
+    monkeypatch.setattr(main, "geocode_address", fake_geocode_address)
+
+    with TestClient(main.app) as client:
+        res = client.get("/api/geocode", params={"query": "Waymo", "limit": 1})
+        assert res.status_code == 200, res.text
+        data = res.json()
+        assert data == [{"display_name": "Waymo HQ", "lat": 37.416, "lng": -122.077}]
+
+
+def test_reverse_geocode_endpoint_returns_rough_and_street(monkeypatch) -> None:
+    def fake_reverse_geocode(lat: float, lng: float, *, zoom: int = 10) -> ReverseGeocodeResult:
+        assert zoom == 18
+        assert lat == 37.416
+        assert lng == -122.077
+        return ReverseGeocodeResult(
+            display_name="690 E Middlefield Rd, Mountain View, CA 94043, USA",
+            address={"city": "Mountain View", "state": "CA", "road": "E Middlefield Rd"},
+        )
+
+    monkeypatch.setattr(main, "reverse_geocode", fake_reverse_geocode)
+
+    with TestClient(main.app) as client:
+        res = client.get(
+            "/api/reverse_geocode", params={"lat": 37.416, "lng": -122.077, "zoom": 18}
+        )
+        assert res.status_code == 200, res.text
+        data = res.json()
+        assert data["rough_location"] == "Mountain View, CA"
+        assert data["approx_street"] == "E Middlefield Rd"
+
+
+def test_upsert_target_address_only_geocodes(monkeypatch) -> None:
+    def fake_geocode_address(query: str, *, limit: int = 5) -> list[GeocodeResult]:
+        assert "Middlefield" in query
+        assert limit == 1
+        return [GeocodeResult(display_name="Waymo HQ", lat=37.416, lng=-122.077)]
+
+    monkeypatch.setattr(main, "geocode_address", fake_geocode_address)
+
+    with TestClient(main.app) as client:
+        res = client.post(
+            "/api/targets",
+            json={
+                "name": "Workplace",
+                "address": "690 E Middlefield Rd, Mountain View, CA 94043",
+            },
+        )
+        assert res.status_code == 200, res.text
+        data = res.json()
+        assert data["name"] == "Workplace"
+        assert data["address"] == "690 E Middlefield Rd, Mountain View, CA 94043"
+        assert data["lat"] == 37.416
+        assert data["lng"] == -122.077
+
+
+def test_upsert_target_coords_only_reverse_geocodes(monkeypatch) -> None:
+    def fake_reverse_geocode(lat: float, lng: float, *, zoom: int = 10) -> ReverseGeocodeResult:
+        assert zoom == 14
+        return ReverseGeocodeResult(
+            display_name="Mountain View, CA 94043, USA",
+            address={"city": "Mountain View", "state": "CA"},
+        )
+
+    monkeypatch.setattr(main, "reverse_geocode", fake_reverse_geocode)
+
+    with TestClient(main.app) as client:
+        res = client.post(
+            "/api/targets",
+            json={"name": "Workplace", "lat": 37.416, "lng": -122.077},
+        )
+        assert res.status_code == 200, res.text
+        data = res.json()
+        assert data["address"] == "Mountain View, CA"
+        assert data["lat"] == 37.416
+        assert data["lng"] == -122.077
+
+
+def test_target_rejects_both_address_and_coords() -> None:
+    with TestClient(main.app) as client:
+        res = client.post(
+            "/api/targets",
+            json={
+                "name": "Workplace",
+                "address": "690 E Middlefield Rd, Mountain View, CA 94043",
+                "lat": 37.416,
+                "lng": -122.077,
+            },
+        )
+        assert res.status_code == 422, res.text
+
+
+def test_compare_computes_distance_and_preserves_listing_order(monkeypatch) -> None:
+    def fake_reverse_geocode(lat: float, lng: float, *, zoom: int = 10) -> ReverseGeocodeResult:
+        return ReverseGeocodeResult(display_name="Mountain View, CA", address={"city": "Mountain View"})
+
+    monkeypatch.setattr(main, "reverse_geocode", fake_reverse_geocode)
+
+    with TestClient(main.app) as client:
+        t = client.post("/api/targets", json={"name": "Workplace", "lat": 37.416, "lng": -122.077})
+        assert t.status_code == 200, t.text
+        target_id = t.json()["id"]
+
+        l1 = client.post(
+            "/api/listings",
+            json={
+                "source": "airbnb",
+                "source_url": "https://www.airbnb.com/rooms/1",
+                "title": "Newer listing",
+                "currency": "USD",
+                "price_period": "unknown",
+                "price_value": 3000,
+                "lat": 37.426,
+                "lng": -122.087,
+                "location_text": "Mountain View, CA",
+                "captured_at": "2026-01-30T12:00:00Z",
+            },
+        )
+        assert l1.status_code == 200, l1.text
+
+        l2 = client.post(
+            "/api/listings",
+            json={
+                "source": "airbnb",
+                "source_url": "https://www.airbnb.com/rooms/2",
+                "title": "Older listing (no coords)",
+                "currency": "USD",
+                "price_period": "unknown",
+                "price_value": 2500,
+                "captured_at": "2026-01-30T10:00:00Z",
+            },
+        )
+        assert l2.status_code == 200, l2.text
+
+        res = client.get("/api/compare", params={"target_id": target_id})
+        assert res.status_code == 200, res.text
+        data = res.json()
+
+        items = data["items"]
+        assert len(items) == 2
+        assert items[0]["listing"]["source_url"] == "https://www.airbnb.com/rooms/1"
+        assert items[1]["listing"]["source_url"] == "https://www.airbnb.com/rooms/2"
+
+        d = items[0]["metrics"]["distance_km"]
+        assert d is not None
+        expected = haversine_km(37.426, -122.087, 37.416, -122.077)
+        assert abs(d - expected) < 1e-6
+
+        assert items[1]["metrics"]["distance_km"] is None
+