docs: add remark for sensitive data

DennisDyallo · DennisDyallo · commit 09dd9ae75059 · 2025-05-07T12:57:12.000+02:00
diff --git a/Yubico.YubiKey/src/Yubico/YubiKey/Piv/Converters/KeyExtensions.cs b/Yubico.YubiKey/src/Yubico/YubiKey/Piv/Converters/KeyExtensions.cs
@@ -53,6 +53,7 @@ public static Memory<byte> EncodeAsPiv(this IPublicKey parameters) =>
     /// <param name="parameters">The private key parameters to encode.</param>
     /// <returns>A BER encoded byte array containing the encoded private key.</returns>
     /// <exception cref="ArgumentException">Thrown when the key type is not supported or when RSA key components have invalid lengths.</exception>
+    /// <remarks>This method returns a newly allocated array containing sensitive information.</remarks>
     public static Memory<byte> EncodeAsPiv(this IPrivateKey parameters) =>
         parameters switch
         {

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ public static Memory<byte> EncodeAsPiv(this IPublicKey parameters) =>`
`53`	`53`	`/// <param name="parameters">The private key parameters to encode.</param>`
`54`	`54`	`/// <returns>A BER encoded byte array containing the encoded private key.</returns>`
`55`	`55`	`/// <exception cref="ArgumentException">Thrown when the key type is not supported or when RSA key components have invalid lengths.</exception>`
	`56`	`+ /// <remarks>This method returns a newly allocated array containing sensitive information.</remarks>`
`56`	`57`	`public static Memory<byte> EncodeAsPiv(this IPrivateKey parameters) =>`
`57`	`58`	`parameters switch`
`58`	`59`	`{`