Update Yubico.YubiKey/src/Yubico/YubiKey/YubiKeyDeviceInfo.cs

DennisDyallo · Copilot · web-flow · commit 0e46a662a21a · 2025-06-09T17:45:06.000+02:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/Yubico.YubiKey/src/Yubico/YubiKey/YubiKeyDeviceInfo.cs b/Yubico.YubiKey/src/Yubico/YubiKey/YubiKeyDeviceInfo.cs
@@ -294,15 +294,15 @@ internal static YubiKeyDeviceInfo CreateFromResponseData(Dictionary<int, ReadOnl
 
                 if (!data.TryGetValue(TAG_VERSION, out var firmwareVersionBytes))
                 {
-                    throw new ArgumentException("TODO.");
+                    throw new ArgumentException("Missing TLV field: TAG_VERSION.");
                 }
                 if (!data.TryGetValue(TAG_TYPE, out var versionTypeBytes))
                 {
-                    throw new ArgumentException("TODO.");
+                    throw new ArgumentException("Missing TLV field: TAG_TYPE.");
                 }
                 if (!data.TryGetValue(TAG_ITERATION, out var iterationBytes))
                 {
-                    throw new ArgumentException("TODO.");
+                    throw new ArgumentException("Missing TLV field: TAG_ITERATION.");
                 }
 
                 var qualifierVersion = FirmwareVersion.FromBytes(firmwareVersionBytes.Span);

Original file line number	Diff line number	Diff line change
`@@ -294,15 +294,15 @@ internal static YubiKeyDeviceInfo CreateFromResponseData(Dictionary<int, ReadOnl`
`294`	`294`
`295`	`295`	`if (!data.TryGetValue(TAG_VERSION, out var firmwareVersionBytes))`
`296`	`296`	`{`
`297`		`- throw new ArgumentException("TODO.");`
	`297`	`+ throw new ArgumentException("Missing TLV field: TAG_VERSION.");`
`298`	`298`	`}`
`299`	`299`	`if (!data.TryGetValue(TAG_TYPE, out var versionTypeBytes))`
`300`	`300`	`{`
`301`		`- throw new ArgumentException("TODO.");`
	`301`	`+ throw new ArgumentException("Missing TLV field: TAG_TYPE.");`
`302`	`302`	`}`
`303`	`303`	`if (!data.TryGetValue(TAG_ITERATION, out var iterationBytes))`
`304`	`304`	`{`
`305`		`- throw new ArgumentException("TODO.");`
	`305`	`+ throw new ArgumentException("Missing TLV field: TAG_ITERATION.");`
`306`	`306`	`}`
`307`	`307`
`308`	`308`	`var qualifierVersion = FirmwareVersion.FromBytes(firmwareVersionBytes.Span);`