fix: OathSession not clearing KeyCollector on disposal

DennisDyallo · DennisDyallo · commit 1160d51b5a66 · 2024-12-19T14:08:41.000+01:00
diff --git a/Yubico.YubiKey/src/Yubico/YubiKey/Oath/OathSession.cs b/Yubico.YubiKey/src/Yubico/YubiKey/Oath/OathSession.cs
@@ -127,11 +127,9 @@ protected override void Dispose(bool disposing)
         {
             if (disposing)
             {
-                return;
+                KeyCollector = null;
+                base.Dispose(disposing);
             }
-
-            KeyCollector = null;
-            base.Dispose(disposing);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -127,11 +127,9 @@ protected override void Dispose(bool disposing)`
`127`	`127`	`{`
`128`	`128`	`if (disposing)`
`129`	`129`	`{`
`130`		`- return;`
	`130`	`+ KeyCollector = null;`
	`131`	`+ base.Dispose(disposing);`
`131`	`132`	`}`
`132`		`-`
`133`		`- KeyCollector = null;`
`134`		`- base.Dispose(disposing);`
`135`	`133`	`}`
`136`	`134`	`}`
`137`	`135`	`}`