misc: add Microsoft.Bcl.Cryptography package reference and update certificate loading method

DennisDyallo · DennisDyallo · commit 1ffc0ca554c4 · 2025-02-07T10:13:45.000+01:00
diff --git a/Yubico.YubiKey/tests/utilities/Yubico.YubiKey.TestUtilities.csproj b/Yubico.YubiKey/tests/utilities/Yubico.YubiKey.TestUtilities.csproj
@@ -31,6 +31,7 @@ limitations under the License. -->
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.Bcl.Cryptography" Version="9.0.0" />
     <PackageReference Include="Moq" Version="4.16.1" />
     <PackageReference Include="Xunit.SkippableFact" Version="1.4.13" />
   </ItemGroup>
diff --git a/Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/TestKeys.cs b/Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/TestKeys.cs
@@ -164,7 +164,7 @@ private TestCertificate(string filePath, bool isAttestation) : base(filePath)
         /// <returns>X509Certificate2 instance initialized with the certificate data</returns>
         public X509Certificate2 AsX509Certificate2()
         {
-            return new X509Certificate2(_bytes);
+            return X509CertificateLoader.LoadCertificate(_bytes);
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ private TestCertificate(string filePath, bool isAttestation) : base(filePath)`
`164`	`164`	`/// <returns>X509Certificate2 instance initialized with the certificate data</returns>`
`165`	`165`	`public X509Certificate2 AsX509Certificate2()`
`166`	`166`	`{`
`167`		`- return new X509Certificate2(_bytes);`
	`167`	`+ return X509CertificateLoader.LoadCertificate(_bytes);`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`/// <summary>`