tests: minor refactor for tests in PivSession

Author: DennisDyallo

Yubico.YubiKey/tests/integration/Yubico/YubiKey/Piv/PinNoCollectorTests.cs

@@ -96,7 +96,6 @@ public void ChangePuk_Succeeds(
 
             using (var pivSession = GetSession(authenticate: false))
             {
-                pivSession.ResetApplication();
                 var isValid = pivSession.TryChangePuk(DefaultPuk, ComplexPuk, out var retriesRemaining);
                 Assert.True(isValid);
                 Assert.Null(retriesRemaining);

Yubico.YubiKey/tests/integration/Yubico/YubiKey/Piv/PivSessionIntegrationTestBase.cs

@@ -22,12 +22,12 @@ namespace Yubico.YubiKey.Piv;
 
 public class PivSessionIntegrationTestBase : IDisposable
 {
-    public static readonly ReadOnlyMemory<byte> DefaultPin = "123456"u8.ToArray();
-    public static readonly ReadOnlyMemory<byte> DefaultPuk = "12345678"u8.ToArray();
-    public static readonly ReadOnlyMemory<byte> ComplexPuk = "gjH@5K!8"u8.ToArray();
-    public static readonly ReadOnlyMemory<byte> ComplexPin = "1@$#5s!8"u8.ToArray();
+    public static Memory<byte> DefaultPin => "123456"u8.ToArray();
+    public static Memory<byte> DefaultPuk => "12345678"u8.ToArray();
+    public static Memory<byte> ComplexPuk => "gjH@5K!8"u8.ToArray();
+    public static Memory<byte> ComplexPin => "1@$#5s!8"u8.ToArray();
 
-    public static readonly ReadOnlyMemory<byte> DefaultManagementKey = new byte[] // Both Aes and TDes
+    public static Memory<byte> DefaultManagementKey => new byte[] // Both Aes and TDes
     {
         0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
         0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
@@ -38,6 +38,10 @@ public class PivSessionIntegrationTestBase : IDisposable
         Device.FirmwareVersion > FirmwareVersion.V5_7_0 ? KeyType.AES192 : KeyType.TripleDES;
 
     protected StandardTestDevice TestDeviceType { get; set; } = StandardTestDevice.Fw5;
+    
+    /// <summary>
+    /// Returns an authenticated PivSession.
+    /// </summary>
     protected PivSession Session => _session ??= GetSession(true);
     protected IYubiKeyDevice Device => IntegrationTestDeviceEnumeration.GetTestDevice(TestDeviceType);
 

Yubico.YubiKey/tests/integration/Yubico/YubiKey/Piv/Simple39KeyCollector.cs

@@ -151,8 +151,8 @@ keyEntryData.RetriesRemaining is not null &&
             return true;
         }
 
-        public static Memory<byte> CollectPin() => PivSessionIntegrationTestBase.DefaultPin.ToArray();
-        public static Memory<byte> CollectPuk() => PivSessionIntegrationTestBase.DefaultPuk.ToArray();
-        public static Memory<byte> CollectMgmtKey() => PivSessionIntegrationTestBase.DefaultManagementKey.ToArray();
+        public static Memory<byte> CollectPin() => PivSessionIntegrationTestBase.DefaultPin;
+        public static Memory<byte> CollectPuk() => PivSessionIntegrationTestBase.DefaultPuk;
+        public static Memory<byte> CollectMgmtKey() => PivSessionIntegrationTestBase.DefaultManagementKey;
     }
 }

Yubico.YubiKey/tests/unit/Yubico/YubiKey/TestUtilities/RandomObjectUtilityTests.cs

@@ -0,0 +1,49 @@
+// Copyright 2024 Yubico AB
+// 
+// Licensed under the Apache License, Version 2.0 (the "License").
+// You may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// 
+//     http://www.apache.org/licenses/LICENSE-2.0
+// 
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+using System.Linq;
+using Xunit;
+using Yubico.YubiKey.Cryptography;
+
+namespace Yubico.YubiKey.TestUtilities;
+
+public class RandomObjectUtilityTests
+{
+    [Fact]
+    public void FixedBytes_Replace()
+    {
+        byte[] fixedBytes =
+        {
+            0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18,
+            0x21, 0x22, 0x23, 0x24, 0x25, 0x26, 0x27, 0x28,
+            0x31, 0x32, 0x33, 0x34, 0x35, 0x36, 0x37, 0x38,
+            0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48
+        };
+
+        var replacement = RandomObjectUtility.SetRandomProviderFixedBytes(fixedBytes);
+
+        try
+        {
+            var random = CryptographyProviders.RngCreator();
+            var randomBytes = new byte[32];
+            random.GetBytes(randomBytes);
+            var compareResult = randomBytes.SequenceEqual(fixedBytes);
+            Assert.True(compareResult);
+        }
+        finally
+        {
+            replacement.RestoreRandomProvider();
+        }
+    }
+}