misc: throw NotSupportedException for unsupported algorithms in GetOidByAlgorithm

DennisDyallo · DennisDyallo · commit 3565df7f64d3 · 2025-01-28T18:30:07.000+01:00
diff --git a/Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/EcdsaVerify.cs b/Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/EcdsaVerify.cs
@@ -462,7 +462,7 @@ private static string GetOidByAlgorithm(CoseAlgorithmIdentifier algorithm)
                 CoseAlgorithmIdentifier.ECDHwHKDF256 => KeyDefinitions.KeyOids.P256,
                 CoseAlgorithmIdentifier.ES384 => KeyDefinitions.KeyOids.P384,
                 CoseAlgorithmIdentifier.ES512 => KeyDefinitions.KeyOids.P521,
-                _ => "",
+                _ => throw new NotSupportedException(ExceptionMessages.UnsupportedAlgorithm)
             };
         }
 

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,7 @@ private static string GetOidByAlgorithm(CoseAlgorithmIdentifier algorithm)`
`462`	`462`	`CoseAlgorithmIdentifier.ECDHwHKDF256 => KeyDefinitions.KeyOids.P256,`
`463`	`463`	`CoseAlgorithmIdentifier.ES384 => KeyDefinitions.KeyOids.P384,`
`464`	`464`	`CoseAlgorithmIdentifier.ES512 => KeyDefinitions.KeyOids.P521,`
`465`		`- _ => "",`
	`465`	`+ _ => throw new NotSupportedException(ExceptionMessages.UnsupportedAlgorithm)`
`466`	`466`	`};`
`467`	`467`	`}`
`468`	`468`