tests:

AttestTests - added comment on CreateAttestationStatement
Added test for Ed25519 attest

Fix tests in PivSessionTests

Author: DennisDyallo

Yubico.YubiKey/tests/integration/Yubico/YubiKey/Piv/AttestTests.cs

@@ -56,27 +56,20 @@ public void Attest_Imported_ThrowsException(
         [InlineData(KeyType.RSA3072, StandardTestDevice.Fw5)]
         [InlineData(KeyType.RSA4096, StandardTestDevice.Fw5)]
         [InlineData(KeyType.ECP256, StandardTestDevice.Fw5)]
-        [InlineData(KeyType.ECP384, StandardTestDevice.Fw5)]
+        [InlineData(KeyType.Ed25519, StandardTestDevice.Fw5)]
         public void AttestGenerated(
             KeyType keyType,
             StandardTestDevice deviceType)
         {
             TestDeviceType = deviceType;
-
             const byte slotNumber = PivSlot.Retired1;
-            _ = Session.GenerateKeyPair(
-                slotNumber, keyType, PivPinPolicy.Never, PivTouchPolicy.Never);
+            Session.GenerateKeyPair(slotNumber, keyType, PivPinPolicy.Never, PivTouchPolicy.Never);
 
-            X509Certificate2? cert = null;
-            try
-            {
-                cert = Session.CreateAttestationStatement(slotNumber);
-                Assert.NotEqual(1, cert.Version);
-            }
-            finally
-            {
-                cert?.Dispose();
-            }
+            // If this test fails, it's possible the attestation key or cert is missing or broken.
+            // In that case, run LoadAttestationPair(KeyType, true) to fix the problem.
+            var cert = Session.CreateAttestationStatement(slotNumber);
+            
+            Assert.NotEqual(1, cert.Version);
         }
 
         [Theory]
@@ -86,7 +79,7 @@ public void GetAttestationCert_ReturnsCert(
         {
             TestDeviceType = deviceType;
 
-            LoadAttestationPair(KeyType.ECP384, true);
+            LoadAttestationPair(KeyType.ECP256, true);
 
             X509Certificate2? cert = null;
             try