misc: added logging when generate key

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/Piv/PivSession.KeyPairs.cs

@@ -18,6 +18,7 @@
 using System.IO.Compression;
 using System.Security;
 using System.Security.Cryptography.X509Certificates;
+using Microsoft.Extensions.Logging;
 using Yubico.Core.Tlv;
 using Yubico.YubiKey.Cryptography;
 using Yubico.YubiKey.Piv.Commands;
@@ -60,7 +61,7 @@ public PivPublicKey GenerateKeyPair(
             return response.GetData();
         }
 
-                /// <summary>
+        /// <summary>
         /// Generate a new key pair in the given slot.
         /// </summary>
         /// <remarks>
@@ -164,12 +165,19 @@ public IPublicKey GenerateKeyPair(
             PivPinPolicy pinPolicy = PivPinPolicy.Default,
             PivTouchPolicy touchPolicy = PivTouchPolicy.Default)
         {
+            Logger.LogInformation("Generating key pair.");
+            
             YubiKey.ThrowIfUnsupportedAlgorithm(keyType.GetPivAlgorithm());
 
             RefreshManagementKeyAuthentication();
 
             var command = new GenerateKeyPairCommand(slotNumber, keyType, pinPolicy, touchPolicy);
             var response = Connection.SendCommand(command);
+            
+            if (response.Status != ResponseStatus.Success)
+            {
+                throw new InvalidOperationException("Error generating key pair: " + response);
+            }
 
             return PivKeyDecoder.CreatePublicKey(response.Data, keyType);
         }