misc: update algorithm entry in CoseEcPublicKey and clean up CoseEdDsaPublicKey documentation; rename test classes and methods for clarity

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/Fido2/Cose/CoseEcPublicKey.cs

@@ -295,10 +295,8 @@ public override byte[] Encode()
 
             return new CborMapWriter<int>()
                 .Entry(TagKeyType, (int)CoseKeyType.Ec2)
-
-                // .Entry(TagAlgorithm, (int)Algorithm) // Should be correct, right? Instead of -25
-                .Entry(
-                    TagAlgorithm, (int)CoseAlgorithmIdentifier.ECDHwHKDF256) // Should be correct, right? Instead of -25
+                // .Entry(TagAlgorithm, (int)Algorithm) // Should be correct, right? Instead of hardcoding -25
+                .Entry(TagAlgorithm, (int)CoseAlgorithmIdentifier.ECDHwHKDF256)
                 .Entry(TagCurve, (int)Curve)
                 .Entry(TagX, XCoordinate)
                 .Entry(TagY, YCoordinate)

Yubico.YubiKey/src/Yubico/YubiKey/Fido2/Cose/CoseEdDsaPublicKey.cs

@@ -31,12 +31,6 @@ namespace Yubico.YubiKey.Fido2.Cose
     /// in RFC8152: CBOR Object Signing and Encryption (COSE) standard. Supplementary information can be found in
     /// section 6.5.6 of the CTAP2.1 specification (under the heading `getPublicKey()`).
     /// </para>
-    /// <para>
-    /// This class has multiple constructors. One constructs an empty object and allows the caller to set the key
-    /// parameters via the properties on this class. Another constructs a key based on the COSE form encoded in CBOR.
-    /// Lastly, there is a constructor that takes in a .NET representation of an EC public key used for interoperating
-    /// with the .NET cryptographic library.
-    /// </para>
     /// </remarks>
     public class CoseEdDsaPublicKey : CoseKey
     {

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/EcdsaVerifyTests.cs

@@ -25,7 +25,7 @@ namespace Yubico.YubiKey.Cryptography
     public class EcdsaVerifyTests
     {
         [Fact]
-        public void PivKey_VerifDigestedDatay_Succeeds()
+        public void PivKey_VerifDigestedData_Succeeds()
         {
             var pubKey = new PivEccPublicKey(GetEncodedPoint());
             byte[] digest = GetDigest();
@@ -37,7 +37,7 @@ public void PivKey_VerifDigestedDatay_Succeeds()
         }
 
         [Fact]
-        public void CoseKey_VeriDigestedDatafy_Succeeds()
+        public void CoseKey_VeriDigestedData_Succeeds()
         {
             var pubKey = new CoseEcPublicKey(CoseEcCurve.P256, GetX(), GetY());
             byte[] digest = GetDigest();

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Fido2/Cose/CosePublicEcKeyTests.cs renamed to Yubico.YubiKey/tests/unit/Yubico/YubiKey/Fido2/Cose/CoseEcPublicKeyTests.cs

@@ -19,7 +19,7 @@
 
 namespace Yubico.YubiKey.Fido2.Cose
 {
-    public class CosePublicEcKeyTests
+    public class CoseEcPublicKeyTests
     {
         [Theory]
         [InlineData(KeyDefinitions.KeyOids.P256)]

Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/IntegrationTestDeviceEnumeration.cs

@@ -41,19 +41,19 @@ namespace Yubico.YubiKey.TestUtilities
     /// </summary>
     public sealed class IntegrationTestDeviceEnumeration
     {
-        // 1. Constants (private, then public)
+
         private const string YUBIKEY_INTEGRATIONTEST_ALLOWED_KEYS_VAR_NAME = "YUBIKEY_INTEGRATIONTEST_ALLOWEDKEYS";
 
-        // 2. Static Fields
+
         private static readonly Lazy<IntegrationTestDeviceEnumeration> LazyInstance =
             new Lazy<IntegrationTestDeviceEnumeration>(() => new IntegrationTestDeviceEnumeration());
 
-        // 3. Instance Fields (readonly, then regular)
+
         private readonly string _allowlistFileName = $"{YUBIKEY_INTEGRATIONTEST_ALLOWED_KEYS_VAR_NAME}.txt";
         private readonly string? _configDirectory;
         public readonly HashSet<string> AllowedSerialNumbers;
 
-        // 4. Properties
+
         private string SetupMessage => "In order to prevent you from accidentally wiping your own important keys," +
                     "you must add your allow-listed Yubikeys serial number to either the environment variable " +
                     $"'{YUBIKEY_INTEGRATIONTEST_ALLOWED_KEYS_VAR_NAME}' or to the file {_allowlistFileName} at {AllowListFilePath}\n" +