fix: EcdsaVerify cannot be Ed25519

DennisDyallo · web-flow · commit 5b1352dcb474 · 2025-05-26T12:22:08.000+02:00
diff --git a/Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/EcdsaVerify.cs b/Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/EcdsaVerify.cs
@@ -173,15 +173,14 @@ public EcdsaVerify(PivPublicKey pivPublicKey)
             ECDsa = ConvertPublicKey(publicPointSpan.ToArray());
         }
         
-        // TODO Test
         public EcdsaVerify(ECPublicKey publicKey)
         {
             if (publicKey is null)
             {
                 throw new ArgumentNullException(nameof(publicKey));
             }
 
-            if (!publicKey.KeyType.IsECDsa() || !publicKey.KeyType.IsCurve25519())
+            if (!publicKey.KeyType.IsECDsa())
             {
                 throw new ArgumentException("Invalid key type", nameof(publicKey));
             }

Original file line number	Diff line number	Diff line change
`@@ -173,15 +173,14 @@ public EcdsaVerify(PivPublicKey pivPublicKey)`
`173`	`173`	`ECDsa = ConvertPublicKey(publicPointSpan.ToArray());`
`174`	`174`	`}`
`175`	`175`
`176`		`- // TODO Test`
`177`	`176`	`public EcdsaVerify(ECPublicKey publicKey)`
`178`	`177`	`{`
`179`	`178`	`if (publicKey is null)`
`180`	`179`	`{`
`181`	`180`	`throw new ArgumentNullException(nameof(publicKey));`
`182`	`181`	`}`
`183`	`182`
`184`		`- if (!publicKey.KeyType.IsECDsa() \|\| !publicKey.KeyType.IsCurve25519())`
	`183`	`+ if (!publicKey.KeyType.IsECDsa())`
`185`	`184`	`{`
`186`	`185`	`throw new ArgumentException("Invalid key type", nameof(publicKey));`
`187`	`186`	`}`