Merge pull request #225

feat: Expose the cbor raw data from a MakeCredential command

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/Fido2/MakeCredentialData.cs

@@ -16,7 +16,6 @@
 using System.Collections.Generic;
 using System.Formats.Cbor;
 using System.Globalization;
-using System.Security.Cryptography;
 using System.Security.Cryptography.X509Certificates;
 using Yubico.YubiKey.Cryptography;
 using Yubico.YubiKey.Fido2.Cbor;
@@ -167,6 +166,12 @@ public class MakeCredentialData
         /// </summary>
         public ReadOnlyMemory<byte>? LargeBlobKey { get; private set; }
 
+
+        /// <summary>
+        /// This returns the raw CBOR encoded credential data from the YubiKey, as returned by the MakeCredential operation.
+        /// </summary>
+        public ReadOnlyMemory<byte> RawData { get; }
+
         // The default constructor explicitly defined. We don't want it to be
         // used.
         private MakeCredentialData()
@@ -193,10 +198,11 @@ private MakeCredentialData()
         /// </exception>
         public MakeCredentialData(ReadOnlyMemory<byte> cborEncoding)
         {
+            RawData = cborEncoding;
+            var map = new CborMap<int>(RawData);
+            
             try
             {
-                var map = new CborMap<int>(cborEncoding);
-
                 Format = map.ReadTextString(KeyFormat);
                 AuthenticatorData = new AuthenticatorData(map.ReadByteString(KeyAuthData));
                 if (!(AuthenticatorData.CredentialPublicKey is CoseEcPublicKey)

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Fido2/CredentialDataTests.cs

@@ -18,6 +18,15 @@ namespace Yubico.YubiKey.Fido2
 {
     public class CredentialDataTests
     {
+        [Fact]
+        public void RawCredentialData_Is_Set()
+        {
+            byte[] encoding = GetSampleEncoding();
+            var cData = new MakeCredentialData(encoding);
+            Assert.Equal(encoding, cData.RawData);
+        }
+        
+        
         [Fact]
         public void Decode_Format_Correct()
         {