misc: pr feedback

remove comments,
revert test change, simpler complexpin and complexpuk

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/Piv/PivSession.Attestation.cs

@@ -431,9 +431,6 @@ private static bool IsSupportedCert(X509Certificate2 certificate, KeyType keyTyp
                 _ => throw new ArgumentException($"Unsupported key type: {keyType}")
             };
 
-            // var certKeyType = isRsa
-            //     ? KeyDefinitions.GetByRSALength(certificate.PublicKey.Key.KeySize).KeyType
-            //     : GetKeyTypeForECDsa(certificate);
             bool isSameAlgorithm = certKeyType == keyType;
             byte[] certDer = certificate.GetRawCertData();
             return certificate.Handle != IntPtr.Zero &&

Yubico.YubiKey/tests/integration/Yubico/YubiKey/Fido2/LargeBlobTests.cs

@@ -45,13 +45,13 @@ public LargeBlobTests()
         [SkippableFact(typeof(DeviceNotFoundException))]
         public void SetLargeBlob_Succeeds()
         {
-            // bool isValid = Fido2ResetForTest.DoReset(_testDevice.SerialNumber);
-            // Assert.True(isValid);
+            bool isValid = Fido2ResetForTest.DoReset(_testDevice.SerialNumber);
+            Assert.True(isValid);
 
             using (var fido2Session = new Fido2Session(_testDevice))
             {
                 fido2Session.KeyCollector = Fido2ResetForTest.ResetForTestKeyCollectorDelegate;
-                var isValid = fido2Session.TrySetPin(new ReadOnlyMemory<byte>(_pin));
+                isValid = fido2Session.TrySetPin(new ReadOnlyMemory<byte>(_pin));
                 Assert.True(isValid);
 
                 var user1 = new UserEntity(new byte[] { 1, 2, 3, 4 })

Yubico.YubiKey/tests/integration/Yubico/YubiKey/Piv/PivSessionIntegrationTestBase.cs

@@ -25,8 +25,8 @@ public class PivSessionIntegrationTestBase : IDisposable
 {
     public static Memory<byte> DefaultPin => "123456"u8.ToArray();
     public static Memory<byte> DefaultPuk => "12345678"u8.ToArray();
-    public static Memory<byte> ComplexPuk => "gjH@5K!8"u8.ToArray();
-    public static Memory<byte> ComplexPin => "1@$#5s!8"u8.ToArray();
+    public static Memory<byte> ComplexPuk => "11234567"u8.ToArray();
+    public static Memory<byte> ComplexPin => "12234567"u8.ToArray();
 
     public static Memory<byte> DefaultManagementKey => new byte[] // Both Aes and TDes
     {
@@ -42,24 +42,6 @@ public class PivSessionIntegrationTestBase : IDisposable
         0x23, 0x34, 0x45, 0x56, 0x67, 0x78, 0x89, 0x9A
     };
 
-    // public void SetFipsApprovedCredentials(PivSession? session)
-    // {
-    //     session ??= Session;
-    //     session.TryChangePin(DefaultPin, ComplexPin, out _);
-    //     session.TryChangePuk(DefaultPuk, ComplexPuk, out _);
-    //     session.TryChangeManagementKey(DefaultManagementKey, ComplexManagementKey, PivTouchPolicy.Always);
-    //     Assert.True(session.TryVerifyPin(ComplexPin, out _));
-    // }
-
-    // public void SetFipsApprovedCredentials(
-    //     IYubiKeyDevice? device,
-    //     ScpKeyParameters parameters)
-    // {
-    //     device ??= Device;
-    //     using var session = new PivSession(device, parameters);
-    //     SetFipsApprovedCredentials(session);
-    // }
-
     protected KeyType DefaultManagementKeyType =>
         Device.FirmwareVersion > FirmwareVersion.V5_7_0 ? KeyType.AES192 : KeyType.TripleDES;