tests:

remove overlapping test
add docs

Author: DennisDyallo

Yubico.YubiKey/tests/integration/Yubico/YubiKey/Piv/AttestTests.cs

@@ -79,21 +79,6 @@ public void AttestGenerated(
             }
         }
 
-        [Theory]
-        [InlineData(KeyType.RSA2048, StandardTestDevice.Fw5)]
-        [InlineData(KeyType.RSA3072, StandardTestDevice.Fw5)]
-        [InlineData(KeyType.RSA4096, StandardTestDevice.Fw5)]
-        [InlineData(KeyType.ECP256, StandardTestDevice.Fw5)]
-        [InlineData(KeyType.ECP384, StandardTestDevice.Fw5)]
-        public void LoadInvalidCert_Attest_ThrowsException(
-            KeyType keyType,
-            StandardTestDevice deviceType)
-        {
-            TestDeviceType = deviceType;
-
-            _ = Assert.Throws<ArgumentException>(() => LoadAttestationPair(keyType, false));
-        }
-
         [Theory]
         [InlineData(StandardTestDevice.Fw5)]
         public void GetAttestationCert_ReturnsCert(
@@ -140,7 +125,7 @@ public void UseBadAttestPair_CreateStatement_ThrowsInvalidOp(
         // Call this to attempt creating an attestation statement. It should
         // fail. So if the operation throws an exception, it fails, so return
         // true. If the operation does not throw an exception, it did not fail,
-        // so return false.6
+        // so return false.
         private bool AttestationShouldFail(
             int whichPair)
         {

Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/TestCertificate.cs

@@ -46,6 +46,7 @@ private TestCertificate(
     /// Loads a certificate from the TestData directory.
     /// </summary>
     /// <param name="curve">The curve or key type associated with the certificate</param>
+    /// <param name="keyType">keyType to load</param>
     /// <param name="isAttestation">True if loading an attestation certificate</param>
     /// <returns>A TestCertificate instance</returns>
     public static TestCertificate Load(