Skip to content

Commit cb54ca2

Browse files
committed
docs: edited comments
1 parent 43ae8f6 commit cb54ca2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Yubico.YubiKey/src/Yubico/YubiKey/Piv/PivConstants.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ internal static class PivConstants
2727
public const int PrivateRSAExponentQTag = 0x04;
2828
public const int PrivateRSACoefficientTag = 0x05;
2929

30-
public const int PublicECTag = 0x86;
30+
public const int PublicECTag = 0x86; // P-256, P-384, P-521, Ed25519 and X25519
3131

3232
public const int PrivateECDsaTag = 0x06; // P-256, P-384, P-521
3333
public const int PrivateECEd25519Tag = 0x7;

Yubico.YubiKey/src/Yubico/YubiKey/Piv/PivSession.Attestation.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ private static bool IsCertSameAlgorithm(bool isValidCert, X509Certificate2 certi
467467
// is given in bits, and the Length of the encoded key is given
468468
// in bytes, compare ( 2 * (keySize / 8)) + 1.
469469
// That's why the comparison is to (keySize / 4) + 1.
470-
if (certificate.PublicKey.Oid.Value == keyType.ToAlgorithmOid()) // TODO potential bug where FriendlyName can differ on OSs
470+
if (certificate.PublicKey.Oid.Value == keyType.GetAlgorithmOid())
471471
{
472472
returnValue = keySize switch
473473
{

0 commit comments

Comments
 (0)