Skip to content

Commit d7456fe

Browse files
authored
misc: minor work onMakeCredentialData
Added a summary for the RawResponse property. Direct assignment to rawresponse
1 parent a68cf0c commit d7456fe

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

Yubico.YubiKey/src/Yubico/YubiKey/Fido2/MakeCredentialData.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,11 @@ public class MakeCredentialData
166166
/// </summary>
167167
public ReadOnlyMemory<byte>? LargeBlobKey { get; private set; }
168168

169-
public ReadOnlyMemory<byte> RawData { get; private set; }
169+
170+
/// <summary>
171+
/// This returns the CBOR encoded raw response of the MakeCredential operation from the YubiKey
172+
/// </summary>
173+
public ReadOnlyMemory<byte> RawResponse { get; private set; }
170174

171175
// The default constructor explicitly defined. We don't want it to be
172176
// used.
@@ -194,10 +198,8 @@ private MakeCredentialData()
194198
/// </exception>
195199
public MakeCredentialData(ReadOnlyMemory<byte> cborEncoding)
196200
{
201+
RawResponse = cborEncoding;
197202
var map = new CborMap<int>(cborEncoding);
198-
byte[] rawData = new byte[cborEncoding.Length];
199-
cborEncoding.CopyTo(rawData);
200-
RawData = rawData;
201203

202204
try
203205
{

0 commit comments

Comments
 (0)