refactor: correct SHA algorithm mapping and rename test method for clarity

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/EcdsaVerify.cs

@@ -286,7 +286,7 @@ public bool VerifyData(
             {
                 256 => CryptographyProviders.Sha256Creator(),
                 384 => CryptographyProviders.Sha384Creator(),
-                512 => CryptographyProviders.Sha512Creator(),
+                521 => CryptographyProviders.Sha512Creator(),
                 _ => throw new ArgumentException(ExceptionMessages.UnsupportedAlgorithm),
             };
 

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/EcdsaVerifyTests.cs

@@ -144,6 +144,17 @@ public void ECDsa_VerifyDigestedData_WithDerFormat_Succeeds(KeyDefinitions.KeyTy
             Assert.True(isVerified);
         }
 
+        [Fact]
+        public void EncodedKey_VerifyDigestedData_Succeeds()
+        {
+            byte[] pubKey = GetEncodedPoint();
+            byte[] digest = GetDigest();
+            byte[] signature = GetSignature();
+
+            using var verifier = new EcdsaVerify(pubKey);
+            bool isVerified = verifier.VerifyDigestedData(digest, signature);
+            Assert.True(isVerified);
+        }
 
         [Theory]
         [InlineData(KeyDefinitions.KeyType.P256)]
@@ -166,19 +177,6 @@ public void ECDsa_VerifyData_WithDerFormat_Succeeds(KeyDefinitions.KeyType keyTy
             Assert.True(isVerified);
         }
 
-
-        [Fact]
-        public void EncodedKey_Verify_Succeeds()
-        {
-            byte[] pubKey = GetEncodedPoint();
-            byte[] digest = GetDigest();
-            byte[] signature = GetSignature();
-
-            using var verifier = new EcdsaVerify(pubKey);
-            bool isVerified = verifier.VerifyDigestedData(digest, signature);
-            Assert.True(isVerified);
-        }
-
         private byte[] GetEncodedPoint()
         {
             byte[] xCoord = GetX();