refactor(keys): proper naming of public method

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/Curve25519PublicKey.cs

@@ -82,22 +82,10 @@ public override byte[] ExportSubjectPublicKeyInfo() =>
     /// <exception cref="CryptographicException">
     /// Thrown if the public key is invalid.
     /// </exception>
-    public static Curve25519PublicKey CreateFromPkcs8(ReadOnlyMemory<byte> encodedKey)
-    {
-        var reader = new AsnReader(encodedKey, AsnEncodingRules.DER);
-        var seqSubjectPublicKeyInfo = reader.ReadSequence();
-        var seqAlgorithmIdentifier = seqSubjectPublicKeyInfo.ReadSequence();
-
-        string oidAlgorithm = seqAlgorithmIdentifier.ReadObjectIdentifier();
-        byte[] subjectPublicKey = seqSubjectPublicKeyInfo.ReadBitString(out int unusedBitCount);
-        if (unusedBitCount != 0)
-        {
-            throw new CryptographicException("Invalid public key encoding");
-        }
-
-        var keyType = KeyDefinitions.GetKeyTypeByOid(oidAlgorithm);
-        return CreateFromValue(subjectPublicKey, keyType);
-    }
+    public static Curve25519PublicKey CreateFromSubjectPublicKeyInfo(ReadOnlyMemory<byte> subjectPublicKeyInfo) =>
+        AsnPublicKeyDecoder
+            .CreatePublicKey(subjectPublicKeyInfo)
+            .Cast<Curve25519PublicKey>();
 
     /// <summary>
     /// Creates an instance of <see cref="Curve25519PublicKey"/> from the given
@@ -122,4 +110,8 @@ public static Curve25519PublicKey CreateFromValue(ReadOnlyMemory<byte> publicPoi
 
         return new Curve25519PublicKey(publicPoint, keyDefinition);
     }
+
+    [Obsolete("Use CreateFromSubjectPublicKeyInfo instead", false)]
+    public static Curve25519PublicKey CreateFromPkcs8(ReadOnlyMemory<byte> encodedKey) =>
+        CreateFromSubjectPublicKeyInfo(encodedKey);
 }

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/ECPublicKey.cs

@@ -148,6 +148,12 @@ public static ECPublicKey CreateFromValue(ReadOnlyMemory<byte> publicPoint, KeyT
     /// <exception cref="CryptographicException">
     /// Thrown if the public key is invalid.
     /// </exception>
+    public static ECPublicKey CreateFromSubjectPublicKeyInfo(ReadOnlyMemory<byte> encodedKey) =>
+        AsnPublicKeyDecoder
+            .CreatePublicKey(encodedKey)
+            .Cast<ECPublicKey>();
+
+    [Obsolete("Use CreateFromSubjectPublicKeyInfo instead", false)]
     public static ECPublicKey CreateFromPkcs8(ReadOnlyMemory<byte> encodedKey) =>
-        (ECPublicKey)AsnPublicKeyDecoder.CreatePublicKey(encodedKey);
+    CreateFromSubjectPublicKeyInfo(encodedKey);
 }

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/RSAPublicKey.cs

@@ -104,6 +104,13 @@ public static RSAPublicKey CreateFromParameters(RSAParameters parameters)
     /// <exception cref="CryptographicException">
     /// Thrown if the public key is invalid.
     /// </exception>
+    public static RSAPublicKey CreateFromSubjectPublicKeyInfo(ReadOnlyMemory<byte> encodedKey) =>
+        AsnPublicKeyDecoder
+            .CreatePublicKey(encodedKey)
+            .Cast<RSAPublicKey>();
+
+
+    [Obsolete("Use CreateFromSubjectPublicKeyInfo instead", false)]
     public static RSAPublicKey CreateFromPkcs8(ReadOnlyMemory<byte> encodedKey) =>
-        (RSAPublicKey)AsnPublicKeyDecoder.CreatePublicKey(encodedKey);
+        CreateFromSubjectPublicKeyInfo(encodedKey);
 }