Skip to content

Commit 2e0a3ac

Browse files
committed
Address review comments
1 parent 753375d commit 2e0a3ac

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

README

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ throw new RuntimeException("Authentication failed");
370370

371371
Finally, if the previous step was successful, update your database using the
372372
link:https://developers.yubico.com/java-webauthn-server/JavaDoc/webauthn-server-core/2.4.1/com/yubico/webauthn/AssertionResult.html[`AssertionResult`].
373-
Most importantly you should update the signature counter, and the backup state flag if you use it. That might look something like this:
373+
Most importantly, you should update the signature counter. That might look something like this:
374374

375375
[source,java]
376376
----------

webauthn-server-core/src/main/java/com/yubico/webauthn/AssertionRequest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public class AssertionRequest {
5959
* <p>If both this and {@link #getUserHandle() userHandle} are empty, this indicates that this is
6060
* a request for an assertion by a <a
6161
* href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#client-side-discoverable-public-key-credential-source">client-side-discoverable
62-
* credential</a> (passkey), and identification of the user has been deferred until the response
62+
* credential</a> (passkey). Identification of the user is therefore deferred until the response
6363
* is received.
6464
*
6565
* @see <a href="https://passkeys.dev/docs/reference/terms/#passkey">Passkey</a> in <a
@@ -77,7 +77,7 @@ public class AssertionRequest {
7777
* <p>If both this and {@link #getUsername() username} are empty, this indicates that this is a
7878
* request for an assertion by a <a
7979
* href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#client-side-discoverable-public-key-credential-source">client-side-discoverable
80-
* credential</a> (passkey), and identification of the user has been deferred until the response
80+
* credential</a> (passkey). Identification of the user is therefore deferred until the response
8181
* is received.
8282
*
8383
* @see <a href="https://passkeys.dev/docs/reference/terms/#passkey">Passkey</a> in <a
@@ -111,7 +111,7 @@ private AssertionRequest(
111111
* <p>If both this and {@link #getUserHandle()} are empty, this indicates that this is a request
112112
* for an assertion by a <a
113113
* href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#client-side-discoverable-public-key-credential-source">client-side-discoverable
114-
* credential</a> (passkey), and identification of the user has been deferred until the response
114+
* credential</a> (passkey). Identification of the user is therefore deferred until the response
115115
* is received.
116116
*
117117
* @see <a href="https://passkeys.dev/docs/reference/terms/#passkey">Passkey</a> in <a
@@ -130,7 +130,7 @@ public Optional<String> getUsername() {
130130
* <p>If both this and {@link #getUsername()} are empty, this indicates that this is a request for
131131
* an assertion by a <a
132132
* href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#client-side-discoverable-public-key-credential-source">client-side-discoverable
133-
* credential</a> (passkey), and identification of the user has been deferred until the response
133+
* credential</a> (passkey). Identification of the user is therefore deferred until the response
134134
* is received.
135135
*
136136
* @see <a href="https://passkeys.dev/docs/reference/terms/#passkey">Passkey</a> in <a
@@ -227,7 +227,7 @@ public AssertionRequestBuilder publicKeyCredentialRequestOptions(
227227
*
228228
* <p>If this is empty, this indicates that this is a request for an assertion by a <a
229229
* href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#client-side-discoverable-public-key-credential-source">client-side-discoverable
230-
* credential</a> (passkey), and identification of the user has been deferred until the response
230+
* credential</a> (passkey). Identification of the user is therefore deferred until the response
231231
* is received.
232232
*
233233
* @see <a href="https://passkeys.dev/docs/reference/terms/#passkey">Passkey</a> in <a
@@ -245,7 +245,7 @@ public AssertionRequestBuilder username(@NonNull Optional<String> username) {
245245
*
246246
* <p>If this is empty, this indicates that this is a request for an assertion by a <a
247247
* href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#client-side-discoverable-public-key-credential-source">client-side-discoverable
248-
* credential</a> (passkey), and identification of the user has been deferred until the response
248+
* credential</a> (passkey). Identification of the user is therefore deferred until the response
249249
* is received.
250250
*
251251
* @see <a href="https://passkeys.dev/docs/reference/terms/#passkey">Passkey</a> in <a
@@ -268,7 +268,7 @@ public AssertionRequestBuilder username(String username) {
268268
* <p>If both this and {@link #username(String)} are empty, this indicates that this is a
269269
* request for an assertion by a <a
270270
* href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#client-side-discoverable-public-key-credential-source">client-side-discoverable
271-
* credential</a> (passkey), and identification of the user has been deferred until the response
271+
* credential</a> (passkey). Identification of the user is therefore deferred until the response
272272
* is received.
273273
*
274274
* @see <a href="https://passkeys.dev/docs/reference/terms/#passkey">Passkey</a> in <a
@@ -287,7 +287,7 @@ public AssertionRequestBuilder userHandle(@NonNull Optional<ByteArray> userHandl
287287
* <p>If both this and {@link #username(String)} are empty, this indicates that this is a
288288
* request for an assertion by a <a
289289
* href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#client-side-discoverable-public-key-credential-source">client-side-discoverable
290-
* credential</a> (passkey), and identification of the user has been deferred until the response
290+
* credential</a> (passkey). Identification of the user is therefore deferred until the response
291291
* is received.
292292
*
293293
* @see <a href="https://passkeys.dev/docs/reference/terms/#passkey">Passkey</a> in <a

0 commit comments

Comments
 (0)