Skip to content

Commit 482f4a2

Browse files
committed
Rename parseFidoSerNumExtension to parseFidoSernumExtension
"sernum" feels like an atomic term in this case, especially with the background of the OID label `id-fido-gen-ce-sernum`.
1 parent d181f75 commit 482f4a2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

webauthn-server-attestation/src/main/java/com/yubico/webauthn/attestation/CertificateUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ private static byte[] parseSerNum(byte[] bytes) {
4545
}
4646
}
4747

48-
public static Optional<ByteArray> parseFidoSerNumExtension(X509Certificate cert) {
48+
public static Optional<ByteArray> parseFidoSernumExtension(X509Certificate cert) {
4949
return Optional.ofNullable(cert.getExtensionValue(ID_FIDO_GEN_CE_SERNUM))
5050
.map(CertificateUtil::parseSerNum)
5151
.map(ByteArray::new);

webauthn-server-attestation/src/test/scala/com/yubico/webauthn/attestation/CertificateUtilSpec.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class CertificateUtilSpec
6969

7070
val result =
7171
CertificateUtil
72-
.parseFidoSerNumExtension(cert)
72+
.parseFidoSernumExtension(cert)
7373
.toScala
7474
result should equal(Some(sernum))
7575
}
@@ -80,7 +80,7 @@ class CertificateUtilSpec
8080
TestAuthenticator.generateAttestationCertificate(extensions = Nil)
8181
val result =
8282
CertificateUtil
83-
.parseFidoSerNumExtension(cert)
83+
.parseFidoSernumExtension(cert)
8484
.toScala
8585
result should be(None)
8686
}
@@ -107,7 +107,7 @@ class CertificateUtilSpec
107107

108108
val result =
109109
CertificateUtil
110-
.parseFidoSerNumExtension(cert)
110+
.parseFidoSernumExtension(cert)
111111
.toScala
112112

113113
result should equal(Some(ByteArray.fromHex("01AFCEFB")))

0 commit comments

Comments
 (0)