Remove unnecessary .getHex() calls in human-readable messages

Author: emlun

webauthn-server-core/src/main/java/com/yubico/webauthn/FidoU2fAttestationStatementVerifier.java

@@ -87,7 +87,7 @@ private static ByteArray getRawUserPublicKey(AttestationObject attestationObject
     try {
       pubkey = WebAuthnCodecs.importCosePublicKey(pubkeyCose);
     } catch (InvalidKeySpecException | NoSuchAlgorithmException e) {
-      throw ExceptionUtil.wrapAndLog(log, "Failed to decode public key: " + pubkeyCose.getHex(), e);
+      throw ExceptionUtil.wrapAndLog(log, "Failed to decode public key: " + pubkeyCose, e);
     }
 
     final ECPublicKey ecPubkey;

webauthn-server-core/src/main/java/com/yubico/webauthn/data/AuthenticatorData.java

@@ -155,7 +155,7 @@ private static VariableLengthParseResult parseAttestedCredentialData(
         "Attested credential data must contain at least %d bytes, was %d: %s",
         CREDENTIAL_ID_LENGTH_END,
         bytes.length,
-        new ByteArray(bytes).getHex());
+        new ByteArray(bytes));
 
     byte[] credentialIdLengthBytes =
         Arrays.copyOfRange(bytes, CREDENTIAL_ID_LENGTH_INDEX, CREDENTIAL_ID_LENGTH_END);
@@ -179,7 +179,7 @@ private static VariableLengthParseResult parseAttestedCredentialData(
         "Expected credential ID of length %d, but attested credential data and extension data is only %d bytes: %s",
         CREDENTIAL_ID_END,
         bytes.length,
-        new ByteArray(bytes).getHex());
+        new ByteArray(bytes));
 
     ByteArrayInputStream indefiniteLengthBytes =
         new ByteArrayInputStream(

webauthn-server-demo/src/main/java/com/yubico/webauthn/attestation/matcher/ExtensionMatcher.java

@@ -70,7 +70,7 @@ public boolean matches(X509Certificate attestationCertificate, JsonNode paramete
         } catch (IOException e) {
           log.error(
               "Failed to parse extension value as ASN1: {}",
-              new ByteArray(extensionValue).getHex(),
+              new ByteArray(extensionValue),
               e);
         }
       }