Address some IntelliJ code inspection warnings in Scala code

Author: emlun

webauthn-server-core/src/main/scala/com/yubico/scala/util/JavaConverters.scala

@@ -3,6 +3,8 @@ package com.yubico.scala.util
 import java.util.Optional
 import java.util.function.Supplier
 
+import scala.language.implicitConversions
+
 
 case class AsJavaOptional[A](a: Option[A]) {
   def asJava[B >: A]: Optional[B] = a match {
@@ -15,9 +17,7 @@ case class AsScalaOption[A](a: Optional[A]) {
 }
 
 case class AsJavaSupplier[A](a: () => A) {
-  def asJava[B >: A]: Supplier[B] = new Supplier[B] {
-    override def get(): B = a()
-  }
+  def asJava[B >: A]: Supplier[B] = () => a()
 }
 
 object JavaConverters {

webauthn-server-core/src/main/scala/com/yubico/webauthn/FinishRegistrationSteps.scala

@@ -277,7 +277,7 @@ case class FinishRegistrationSteps(
     def attestationTrusted: Boolean = {
       attestationType match {
         case SelfAttestation | NoneAttestation => allowUntrustedAttestation
-        case Basic => attestationMetadata.asScala map { _.isTrusted } getOrElse false
+        case Basic => attestationMetadata.asScala exists { _.isTrusted }
         case _ => ???
       }
     }

webauthn-server-core/src/main/scala/com/yubico/webauthn/data/AuthenticatorData.scala

@@ -18,7 +18,7 @@ import scala.util.Failure
 
 case class AuthenticatorData(
   @JsonIgnore
-  val authData: ArrayBuffer
+  authData: ArrayBuffer
 ) {
   private val RpIdHashLength = 32
   private val FlagsLength = 1

webauthn-server-core/src/main/scala/com/yubico/webauthn/data/CollectedClientData.scala

@@ -16,8 +16,6 @@ case class CollectedClientData(
   private val clientData: JsonNode
 ) {
 
-  private val logger: Logger = LoggerFactory.getLogger(classOf[CollectedClientData])
-
   /**
     * Input or output values for or from authenticator extensions, if any.
     */

webauthn-server-core/src/main/scala/com/yubico/webauthn/impl/PackedAttestationStatementVerifier.scala

@@ -42,10 +42,6 @@ object PackedAttestationStatementVerifier extends AttestationStatementVerifier w
       "attStmt.sig must be set to a binary value."
     )
 
-    val signedData: ArrayBuffer = attestationObject.authenticatorData.authData ++ clientDataJsonHash
-
-    val signature: ArrayBuffer = signatureNode.binaryValue.toVector
-
     if (attestationObject.attestationStatement.has("x5c"))
       verifyX5cSignature(attestationObject, clientDataJsonHash)
     else if (attestationObject.attestationStatement.has("ecdaaKeyId"))

webauthn-server-core/src/main/scala/com/yubico/webauthn/util/BinaryUtil.scala

@@ -89,7 +89,6 @@ object BinaryUtil {
     * Read 4 bytes as a big endian unsigned 32-bit integer.
     *
     * Result is of type Long because Scala/Java don't have unsigned types.
-    * @param bytes
     * @return A value between 0 and 2^32 - 1, inclusive.
     */
   def getUint32(bytes: ArrayBuffer): Try[Long] = Try(