Skip to content

Commit 7fdb57c

Browse files
committed
Fix misspelled references to toCredentials*Json() methods
1 parent 8adbad6 commit 7fdb57c

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

NEWS

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ New features:
3535
sets both the `requireResidentKey` and `residentKey` options simultaneously
3636
and in agreement with each other for backwards compatibility with older
3737
browsers.
38-
* Added methods `PublicKeyCredentialCreationOptions.toCredentialCreateJson()`,
39-
`PublicKeyCredentialRequestOptions.toCredentialGetJson()` and
40-
`AssertionRequest.toCredentialGetJson()` for serializing to JSON without
38+
* Added methods `PublicKeyCredentialCreationOptions.toCredentialsCreateJson()`,
39+
`PublicKeyCredentialRequestOptions.toCredentialsGetJson()` and
40+
`AssertionRequest.toCredentialsGetJson()` for serializing to JSON without
4141
having to use Jackson directly.
4242

4343
Fixes:

README

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ PublicKeyCredentialCreationOptions request = rp.startRegistration(
186186
)
187187
.build());
188188

189-
String credentialCreateJson = request.toCredentialCreateJson();
189+
String credentialCreateJson = request.toCredentialsCreateJson();
190190
return credentialCreateJson; // Send to client
191191
----------
192192

@@ -298,7 +298,7 @@ First, generate authentication parameters and send them to the client:
298298
AssertionRequest request = rp.startAssertion(StartAssertionOptions.builder()
299299
.username("alice")
300300
.build());
301-
String credentialGetJson = request.toCredentialGetJson();
301+
String credentialGetJson = request.toCredentialsGetJson();
302302
return credentialGetJson; // Send to client
303303
----------
304304

webauthn-server-core/src/test/scala/com/yubico/webauthn/data/JsonIoSpec.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ class JsonIoSpec
372372
}
373373

374374
describe("The class PublicKeyCredentialCreationOptions") {
375-
it("""has a toCredentialCreateJson() method which returns a JSON object with the PublicKeyCredentialCreationOptions set as a top-level "publicKey" property.""") {
375+
it("""has a toCredentialsCreateJson() method which returns a JSON object with the PublicKeyCredentialCreationOptions set as a top-level "publicKey" property.""") {
376376
forAll { pkcco: PublicKeyCredentialCreationOptions =>
377377
println(pkcco)
378378
val jsonValue =
@@ -387,7 +387,7 @@ class JsonIoSpec
387387
}
388388

389389
describe("The class PublicKeyCredentialRequestOptions") {
390-
it("""has a toCredentialGetJson() method which returns a JSON object with the PublicKeyCredentialGetOptions set as a top-level "publicKey" property.""") {
390+
it("""has a toCredentialsGetJson() method which returns a JSON object with the PublicKeyCredentialGetOptions set as a top-level "publicKey" property.""") {
391391
forAll { pkcro: PublicKeyCredentialRequestOptions =>
392392
println(pkcro)
393393
val jsonValue = JacksonCodecs.json.readTree(pkcro.toCredentialsGetJson)
@@ -401,7 +401,7 @@ class JsonIoSpec
401401
}
402402

403403
describe("The class AssertionRequest") {
404-
it("""has a toCredentialGetJson() method which returns a JSON object with the PublicKeyCredentialGetOptions set as a top-level "publicKey" property.""") {
404+
it("""has a toCredentialsGetJson() method which returns a JSON object with the PublicKeyCredentialGetOptions set as a top-level "publicKey" property.""") {
405405
forAll { req: AssertionRequest =>
406406
println(req)
407407

0 commit comments

Comments
 (0)