Skip to content

Commit 9de5b72

Browse files
committed
Include attestation object in cert path validation failure logs
1 parent 4d93d4e commit 9de5b72

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

NEWS

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
== Version 2.1.0 (unreleased) ==
22

3+
Changes:
4+
5+
* Log messages on attestation certificate path validation failure now include
6+
the attestation object.
7+
38
Fixes:
49

510
* Fixed various typos and mistakes in JavaDocs.

webauthn-server-core/src/main/java/com/yubico/webauthn/FinishRegistrationSteps.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,14 +543,18 @@ public boolean attestationTrusted() {
543543

544544
} catch (CertPathValidatorException e) {
545545
log.info(
546-
"Failed to derive trust in attestation statement: {} at cert index {}: {}",
546+
"Failed to derive trust in attestation statement: {} at cert index {}: {}. Attestation object: {}",
547+
response.getResponse().getAttestationObject(),
547548
e.getReason(),
548549
e.getIndex(),
549550
e.getMessage());
550551
return false;
551552

552553
} catch (CertificateException e) {
553-
log.warn("Failed to build attestation certificate path.", e);
554+
log.warn(
555+
"Failed to build attestation certificate path. Attestation object: {}",
556+
response.getResponse().getAttestationObject(),
557+
e);
554558
return false;
555559

556560
} catch (NoSuchAlgorithmException e) {

0 commit comments

Comments
 (0)