Add tests for *V2 features

Author: emlun

webauthn-server-core/src/main/java/com/yubico/webauthn/CredentialRecord.java

@@ -1,7 +1,9 @@
 package com.yubico.webauthn;
 
+import com.yubico.webauthn.data.AuthenticatorTransport;
 import com.yubico.webauthn.data.ByteArray;
 import java.util.Optional;
+import java.util.Set;
 import lombok.NonNull;
 
 /**
@@ -20,8 +22,10 @@ public interface CredentialRecord {
 
   long getSignatureCount();
 
-  // @NonNull
-  // Set<AuthenticatorTransport> getTransports();
+  @NonNull
+  default Optional<Set<AuthenticatorTransport>> getTransports() {
+    return Optional.empty();
+  }
 
   // boolean isUvInitialized();
 

webauthn-server-core/src/main/java/com/yubico/webauthn/FinishAssertionSteps.java

@@ -230,6 +230,10 @@ public Step7 nextStep() {
 
     @Override
     public void validate() {
+      assertTrue(
+          !(request.getUsername().isPresent() && !usernameRepository.isPresent()),
+          "Cannot set request username when usernameRepository is not configured.");
+
       assertTrue(
           finalUserHandle.isPresent(),
           "Could not identify user to authenticate: none of requested username, requested user handle or response user handle are set.");

webauthn-server-core/src/main/java/com/yubico/webauthn/RegisteredCredential.java

@@ -32,6 +32,7 @@
 import com.yubico.webauthn.data.AttestedCredentialData;
 import com.yubico.webauthn.data.AuthenticatorAssertionResponse;
 import com.yubico.webauthn.data.AuthenticatorData;
+import com.yubico.webauthn.data.AuthenticatorTransport;
 import com.yubico.webauthn.data.ByteArray;
 import com.yubico.webauthn.data.COSEAlgorithmIdentifier;
 import com.yubico.webauthn.data.PublicKeyCredentialDescriptor;
@@ -41,6 +42,7 @@
 import java.security.PublicKey;
 import java.security.spec.InvalidKeySpecException;
 import java.util.Optional;
+import java.util.Set;
 import lombok.AccessLevel;
 import lombok.Builder;
 import lombok.Getter;
@@ -118,6 +120,8 @@ public PublicKey getParsedPublicKey()
    */
   @Builder.Default private final long signatureCount = 0;
 
+  @Builder.Default private final Set<AuthenticatorTransport> transports = null;
+
   /**
    * The state of the <a href="https://w3c.github.io/webauthn/#authdata-flags-be">BE flag</a> when
    * this credential was registered, if known.
@@ -172,16 +176,23 @@ private RegisteredCredential(
       @NonNull @JsonProperty("userHandle") ByteArray userHandle,
       @NonNull @JsonProperty("publicKeyCose") ByteArray publicKeyCose,
       @JsonProperty("signatureCount") long signatureCount,
+      @JsonProperty("transports") Set<AuthenticatorTransport> transports,
       @JsonProperty("backupEligible") Boolean backupEligible,
       @JsonProperty("backupState") @JsonAlias("backedUp") Boolean backupState) {
     this.credentialId = credentialId;
     this.userHandle = userHandle;
     this.publicKeyCose = publicKeyCose;
     this.signatureCount = signatureCount;
+    this.transports = transports;
     this.backupEligible = backupEligible;
     this.backupState = backupState;
   }
 
+  @Override
+  public Optional<Set<AuthenticatorTransport>> getTransports() {
+    return Optional.ofNullable(transports);
+  }
+
   /**
    * The state of the <a href="https://w3c.github.io/webauthn/#authdata-flags-be">BE flag</a> when
    * this credential was registered, if known.

webauthn-server-core/src/main/java/com/yubico/webauthn/RelyingPartyV2.java

@@ -463,6 +463,11 @@ FinishRegistrationSteps _finishRegistration(FinishRegistrationOptions options) {
   }
 
   public AssertionRequest startAssertion(StartAssertionOptions startAssertionOptions) {
+    if (startAssertionOptions.getUsername().isPresent() && usernameRepository == null) {
+      throw new IllegalArgumentException(
+          "StartAssertionOptions.username must not be set when usernameRepository is not configured.");
+    }
+
     PublicKeyCredentialRequestOptionsBuilder pkcro =
         PublicKeyCredentialRequestOptions.builder()
             .challenge(generateChallenge())