Skip to content

Commit d46c0aa

Browse files
committed
Allow unknown properties in credProps client extension output
1 parent e528ca5 commit d46c0aa

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

NEWS

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
== Version 2.5.2 (unreleased) ==
2+
3+
Fixes:
4+
5+
* Allow unknown properties in `credProps` client extension output.
6+
7+
18
== Version 2.5.1 ==
29

310
Changes:

webauthn-server-core/src/main/java/com/yubico/webauthn/data/ExtensionOutputs.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,15 @@
44
import java.util.Set;
55

66
public interface ExtensionOutputs {
7-
/** Returns a {@link Set} of the extension IDs for which an extension output is present. */
7+
/**
8+
* Returns a {@link Set} of recognized extension IDs for which an extension output is present.
9+
*
10+
* <p>This only includes extension identifiers recognized by the java-webauthn-server library.
11+
* Recognized extensions can be found as the properties of {@link
12+
* ClientRegistrationExtensionOutputs} for registration ceremonies, and {@link
13+
* ClientAssertionExtensionOutputs} for authentication ceremonies. Unknown extension identifiers
14+
* are silently ignored.
15+
*/
816
@JsonIgnore
917
Set<String> getExtensionIds();
1018
}

webauthn-server-core/src/main/java/com/yubico/webauthn/data/Extensions.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.yubico.webauthn.data;
22

33
import com.fasterxml.jackson.annotation.JsonCreator;
4+
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
45
import com.fasterxml.jackson.annotation.JsonProperty;
56
import com.fasterxml.jackson.annotation.JsonValue;
67
import com.upokecenter.cbor.CBORObject;
@@ -63,6 +64,7 @@ public static class CredentialProperties {
6364
* Credential Properties Extension (credProps)</a>
6465
*/
6566
@Value
67+
@JsonIgnoreProperties(ignoreUnknown = true)
6668
public static class CredentialPropertiesOutput {
6769
@JsonProperty("rk")
6870
private final Boolean rk;

0 commit comments

Comments
 (0)