Add public factory function LargeBlobRegistrationOutput.supported(boolean)

Author: emlun

NEWS

@@ -7,6 +7,8 @@ New features:
  ** Thanks to Jakob Heher (A-SIT) for the contribution, see
     https://github.com/Yubico/java-webauthn-server/pull/299
 * Added public builder to `CredentialPropertiesOutput`.
+* Added public factory function
+  `LargeBlobRegistrationOutput.supported(boolean)`.
 * (Experimental) Added option `isSecurePaymentConfirmation(boolean)` to
   `FinishAssertionOptions`. When set, `RelyingParty.finishAssertion()` will
   adapt the validation logic for a Secure Payment Confirmation (SPC) response

webauthn-server-core/src/main/java/com/yubico/webauthn/data/Extensions.java

@@ -216,6 +216,9 @@ public static Set<LargeBlobSupport> values() {
      * Extension inputs for the Large blob storage extension (<code>largeBlob</code>) in
      * authentication ceremonies.
      *
+     * <p>Use the {@link #read()} and {@link #write(ByteArray)} factory functions to construct this
+     * type.
+     *
      * @see <a
      *     href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#sctn-large-blob-extension">§10.5.
      *     Large blob storage extension (largeBlob)</a>
@@ -311,6 +314,8 @@ public Optional<ByteArray> getWrite() {
      * Extension outputs for the Large blob storage extension (<code>largeBlob</code>) in
      * registration ceremonies.
      *
+     * <p>Use the {@link #supported(boolean)} factory function to construct this type.
+     *
      * @see <a
      *     href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#sctn-large-blob-extension">§10.5.
      *     Large blob storage extension (largeBlob)</a>
@@ -328,9 +333,21 @@ public static class LargeBlobRegistrationOutput {
       @JsonProperty private final boolean supported;
 
       @JsonCreator
-      LargeBlobRegistrationOutput(@JsonProperty("supported") boolean supported) {
+      private LargeBlobRegistrationOutput(@JsonProperty("supported") boolean supported) {
         this.supported = supported;
       }
+
+      /**
+       * Create a Large blob storage extension output with the <code>supported</code> output set to
+       * the given value.
+       *
+       * @see <a
+       *     href="https://www.w3.org/TR/2021/REC-webauthn-2-20210408/#dictdef-authenticationextensionslargebloboutputs">
+       *     dictionary AuthenticationExtensionsLargeBlobOutputs</a>
+       */
+      public static LargeBlobRegistrationOutput supported(boolean supported) {
+        return new LargeBlobRegistrationOutput(supported);
+      }
     }
 
     /**

webauthn-server-core/src/test/scala/com/yubico/webauthn/RelyingPartyRegistrationSpec.scala

@@ -54,12 +54,12 @@ import com.yubico.webauthn.data.ClientRegistrationExtensionOutputs
 import com.yubico.webauthn.data.CollectedClientData
 import com.yubico.webauthn.data.Extensions.CredentialProperties.CredentialPropertiesOutput
 import com.yubico.webauthn.data.Extensions.LargeBlob.LargeBlobRegistrationInput.LargeBlobSupport
+import com.yubico.webauthn.data.Extensions.LargeBlob.LargeBlobRegistrationOutput
 import com.yubico.webauthn.data.Extensions.Uvm.UvmEntry
 import com.yubico.webauthn.data.Generators._
 import com.yubico.webauthn.data.PublicKeyCredential
 import com.yubico.webauthn.data.PublicKeyCredentialCreationOptions
 import com.yubico.webauthn.data.PublicKeyCredentialParameters
-import com.yubico.webauthn.data.ReexportHelpers
 import com.yubico.webauthn.data.RegistrationExtensionInputs
 import com.yubico.webauthn.data.RelyingPartyIdentity
 import com.yubico.webauthn.data.UserIdentity
@@ -4302,7 +4302,7 @@ class RelyingPartyRegistrationSpec
                     ClientRegistrationExtensionOutputs
                       .builder()
                       .largeBlob(
-                        ReexportHelpers.newLargeBlobRegistrationOutput(true)
+                        LargeBlobRegistrationOutput.supported(true)
                       )
                       .build()
                   )

webauthn-server-core/src/test/scala/com/yubico/webauthn/RelyingPartyV2RegistrationSpec.scala

@@ -54,12 +54,12 @@ import com.yubico.webauthn.data.ClientRegistrationExtensionOutputs
 import com.yubico.webauthn.data.CollectedClientData
 import com.yubico.webauthn.data.Extensions.CredentialProperties.CredentialPropertiesOutput
 import com.yubico.webauthn.data.Extensions.LargeBlob.LargeBlobRegistrationInput.LargeBlobSupport
+import com.yubico.webauthn.data.Extensions.LargeBlob.LargeBlobRegistrationOutput
 import com.yubico.webauthn.data.Extensions.Uvm.UvmEntry
 import com.yubico.webauthn.data.Generators._
 import com.yubico.webauthn.data.PublicKeyCredential
 import com.yubico.webauthn.data.PublicKeyCredentialCreationOptions
 import com.yubico.webauthn.data.PublicKeyCredentialParameters
-import com.yubico.webauthn.data.ReexportHelpers
 import com.yubico.webauthn.data.RegistrationExtensionInputs
 import com.yubico.webauthn.data.RelyingPartyIdentity
 import com.yubico.webauthn.data.UserIdentity
@@ -4297,7 +4297,7 @@ class RelyingPartyV2RegistrationSpec
                     ClientRegistrationExtensionOutputs
                       .builder()
                       .largeBlob(
-                        ReexportHelpers.newLargeBlobRegistrationOutput(true)
+                        LargeBlobRegistrationOutput.supported(true)
                       )
                       .build()
                   )

webauthn-server-core/src/test/scala/com/yubico/webauthn/data/ExtensionsSpec.scala

@@ -327,7 +327,7 @@ class ExtensionsSpec
         Set("largeBlob")
       )
       registrationCred.getClientExtensionResults.getLargeBlob.toScala should equal(
-        Some(new LargeBlobRegistrationOutput(true))
+        Some(LargeBlobRegistrationOutput.supported(true))
       )
 
       assertionCred.getClientExtensionResults.getExtensionIds.asScala should equal(
@@ -347,7 +347,7 @@ class ExtensionsSpec
         Set("largeBlob")
       )
       registrationCred.getClientExtensionResults.getLargeBlob.toScala should equal(
-        Some(new LargeBlobRegistrationOutput(true))
+        Some(LargeBlobRegistrationOutput.supported(true))
       )
 
       assertionCred.getClientExtensionResults.getExtensionIds.asScala should equal(

webauthn-server-core/src/test/scala/com/yubico/webauthn/data/Generators.scala

@@ -883,7 +883,7 @@ object Generators {
       def largeBlobRegistrationOutput: Gen[LargeBlobRegistrationOutput] =
         for {
           supported <- arbitrary[Boolean]
-        } yield new LargeBlobRegistrationOutput(supported)
+        } yield LargeBlobRegistrationOutput.supported(supported)
 
       def largeBlobAuthenticationInput: Gen[LargeBlobAuthenticationInput] =
         halfsized(

webauthn-server-core/src/test/scala/com/yubico/webauthn/data/ReexportHelpers.scala

@@ -1,17 +1,13 @@
 package com.yubico.webauthn.data
 
 import com.yubico.webauthn.data.Extensions.LargeBlob.LargeBlobAuthenticationOutput
-import com.yubico.webauthn.data.Extensions.LargeBlob.LargeBlobRegistrationOutput
 
 /** Public re-exports of things in the com.yubico.webauthn.data package, so that
   * tests can access them but dependent projects cannot (unless they do this
   * same workaround hack).
   */
 object ReexportHelpers {
 
-  def newLargeBlobRegistrationOutput(
-      supported: Boolean
-  ): LargeBlobRegistrationOutput = new LargeBlobRegistrationOutput(supported)
   def newLargeBlobAuthenticationOutput(
       blob: Option[ByteArray],
       written: Option[Boolean],