Skip to content

Commit f26f36b

Browse files
committed
fixup! Use OptionalUtil.orElseOptional instead of weird Optional-wrapping workaround
1 parent 3ac0b31 commit f26f36b

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

webauthn-server-core/src/main/java/com/yubico/webauthn/FinishRegistrationSteps.java

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import COSE.CoseException;
3131
import com.upokecenter.cbor.CBORObject;
3232
import com.yubico.internal.util.CertificateParser;
33+
import com.yubico.internal.util.OptionalUtil;
3334
import com.yubico.webauthn.attestation.AttestationTrustSource;
3435
import com.yubico.webauthn.attestation.AttestationTrustSource.TrustRootsResult;
3536
import com.yubico.webauthn.data.AttestationObject;
@@ -476,25 +477,22 @@ private Optional<AttestationTrustSource.TrustRootsResult> findTrustRoots() {
476477
atp ->
477478
attestationTrustSource.findTrustRoots(
478479
atp,
479-
Optional.ofNullable(
480+
OptionalUtil.orElseOptional(
480481
Optional.of(
481482
attestation
482483
.getAuthenticatorData()
483484
.getAttestedCredentialData()
484485
.get()
485486
.getAaguid())
486-
.filter(aaguid -> !aaguid.equals(ZERO_AAGUID))
487-
.orElseGet(
488-
() -> {
489-
if (!atp.isEmpty()) {
490-
return CertificateParser.parseFidoAaguidExtension(
491-
atp.get(0))
492-
.map(ByteArray::new)
493-
.orElse(null);
494-
} else {
495-
return null;
496-
}
497-
})))));
487+
.filter(aaguid -> !aaguid.equals(ZERO_AAGUID)),
488+
() -> {
489+
if (!atp.isEmpty()) {
490+
return CertificateParser.parseFidoAaguidExtension(atp.get(0))
491+
.map(ByteArray::new);
492+
} else {
493+
return Optional.empty();
494+
}
495+
}))));
498496
}
499497
}
500498

0 commit comments

Comments
 (0)