Merge pull request #210 from ZFengMo/dev

guansss · web-flow · commit 5c8dee4c1937 · 2023-09-14T11:48:57.000+08:00
feat: refactor OperatorSelect to prevent duplicate selections
diff --git a/src/components/OperatorSelect.tsx b/src/components/OperatorSelect.tsx
@@ -78,7 +78,11 @@ export const OperatorSelect: FC<OperatorSelectProps> = ({
   }
 
   const add = (operation: OperatorInfo) => {
-    change([...new Set([...operators, { name: operation.name }])])
+    if (!operators.some((op) => op.name === operation.name)) {
+      change([...operators, { name: operation.name }])
+    } else {
+      remove(operation)
+    }
   }
 
   const remove = (operation: OperatorInfo) => {

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,11 @@ export const OperatorSelect: FC<OperatorSelectProps> = ({`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`const add = (operation: OperatorInfo) => {`
`81`		`- change([...new Set([...operators, { name: operation.name }])])`
	`81`	`+ if (!operators.some((op) => op.name === operation.name)) {`
	`82`	`+ change([...operators, { name: operation.name }])`
	`83`	`+ } else {`
	`84`	`+ remove(operation)`
	`85`	`+ }`
`82`	`86`	`}`
`83`	`87`
`84`	`88`	`const remove = (operation: OperatorInfo) => {`