Fix: folderIds=0 at get_all_folder_ids_and_names #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ZPascal#125 by simple way the folderIds=0 must be replaced to folderIds=null Issue was intruduced with Grafana 12. Fix is tested with Grafana 11 and 12.
|
@ZPascal Do you have any idea, why several integration tests were failed with below error message? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125 by simple way.
The
folderIds=0must be replaced tofolderIds=nullIssue was intruduced with Grafana 12. Fix is tested with Grafana 11 and 12.
Grafana 12 may use different (version of) CLI parameter parser, which puts the
0as an item ofFolderIds, but the null keeps theFolderIdslist empty, see in Grafana source code:https://github.com/grafana/grafana/blob/60df44bb2366fa79808dda46bb2657a2a1646307/pkg/services/dashboards/database/database.go#L921