You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Junit present on the BOM for oskari-server was updated from JUnit 4 to 5 and JUnit changed the groupId and artifactId in their update. This means that if your app does NOT define a specific version for the JUnit dependency and depend on oskari-server doing it, your app will not compile after updating due to missing dependency version. To fix this you have some options and here's what we've used:
36
46
37
47
- for the sample-server-extension there were no tests so junit was removed from dependencies: https://github.com/oskariorg/sample-server-extension/pull/63
38
48
- for apps that do have tests and don't want to migrate them, you can define the junit 4 dependency version for the app like this: https://github.com/nls-oskari/kartta.paikkatietoikkuna.fi/pull/235
39
49
- for apps that want to migrate to JUnit 5, you can do something like this: https://github.com/nlsfi/oskari-server-extras/pull/31
40
-
50
+
- Changed annotations
51
+
-@Before -> @BeforeEach
52
+
-@After -> @AfterEach
53
+
-@Ignore -> @Disabled()
54
+
- Tests may require @TestInstance(TestInstance.Lifecycle.PER_CLASS) annotation after update
41
55
### Generic proxy removed
42
56
43
57
A proxy implementation was previously used to pass requests from
0 commit comments