simplify read timeout

Author: wizzomafizzo

transport/uart/uart.go

@@ -68,12 +68,10 @@ func isWindows() bool {
 	return runtime.GOOS == "windows"
 }
 
-// getWindowsTimeout returns Windows-specific timeout values
-func getWindowsTimeout() time.Duration {
-	if isWindows() {
-		return 100 * time.Millisecond // Increased for Windows stability
-	}
-	// Relax non-Windows default read timeout to improve reliability with USB-UART
+// getReadTimeout returns the unified read timeout for all platforms
+// Originally Windows needed 100ms while other platforms used 50ms, but Linux users
+// reported intermittent empty data issues, so we unified to 100ms for all platforms
+func getReadTimeout() time.Duration {
 	return 100 * time.Millisecond
 }
 
@@ -96,9 +94,9 @@ func New(portName string) (*Transport, error) {
 		return nil, fmt.Errorf("failed to open UART port %s: %w", portName, err)
 	}
 
-	// Set platform-specific timeout - increased for Windows due to driver differences
-	// 50ms proven to work on Linux/Mac, 100ms needed for Windows stability
-	timeout := getWindowsTimeout()
+	// Set unified read timeout - originally 50ms on Linux/Mac and 100ms on Windows,
+	// but unified to 100ms on all platforms to resolve Linux USB-UART reliability issues
+	timeout := getReadTimeout()
 	if err := port.SetReadTimeout(timeout); err != nil {
 		_ = port.Close()
 		return nil, fmt.Errorf("failed to set UART read timeout: %w", err)

transport/uart/windows_test.go

@@ -38,22 +38,15 @@ func TestWindowsPlatformDetection(t *testing.T) {
 	}
 }
 
-// TestWindowsSpecificTimeout tests Windows-specific timeout values
-func TestWindowsSpecificTimeout(t *testing.T) {
+// TestUnifiedTimeout tests the unified timeout value for all platforms
+func TestUnifiedTimeout(t *testing.T) {
 	t.Parallel()
 
-	timeout := getWindowsTimeout()
+	timeout := getReadTimeout()
+	expectedTimeout := 100 * time.Millisecond
 
-	if runtime.GOOS == "windows" {
-		expectedTimeout := 100 * time.Millisecond
-		if timeout != expectedTimeout {
-			t.Errorf("getWindowsTimeout() on Windows = %v, want %v", timeout, expectedTimeout)
-		}
-	} else {
-		expectedTimeout := 50 * time.Millisecond
-		if timeout != expectedTimeout {
-			t.Errorf("getWindowsTimeout() on non-Windows = %v, want %v", timeout, expectedTimeout)
-		}
+	if timeout != expectedTimeout {
+		t.Errorf("getReadTimeout() = %v, want %v", timeout, expectedTimeout)
 	}
 }
 
@@ -94,7 +87,7 @@ func TestWindowsIntegrationFunctions(t *testing.T) {
 	}
 
 	// Test timeout function
-	timeout := getWindowsTimeout()
+	timeout := getReadTimeout()
 	if timeout <= 0 {
 		t.Errorf("Invalid timeout: %v", timeout)
 	}